Skip to content

Request cloud-platform scope in ControlPlaneClient credentials (fixes #4) #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lokic233 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Request cloud-platform scope in ControlPlaneClient credentials (fixes #4) #5

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions src/google_cloud_mldiagnostics/clients/control_plane_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,8 +88,20 @@ def __init__(
self.base_url = base_url
self.ml_runs_path = f"{base_url}/projects/{project_id}/locations/{location}/machineLearningRuns"

# Initialize Google Cloud credentials
self.credentials, _ = google.auth.default()
# Initialize Google Cloud credentials.
#
# Request the cloud-platform scope explicitly. Some credential types do not
# carry an implicit scope -- notably external_account (Workload Identity
# Federation) credentials, e.g. a GKE workload authenticating as a service
# account via WIF. With such a credential, google.auth.default() with no
# scopes yields an unscoped credential, and the subsequent STS token
# exchange / service-account impersonation is malformed, so the control
# plane rejects every request with HTTP 400 INVALID_ARGUMENT. Passing the
# scope explicitly makes token minting well-formed for both user ADC and
# external_account credentials.
self.credentials, _ = google.auth.default(
scopes=["https://www.googleapis.com/auth/cloud-platform"]
)

def _get_access_token(self) -> str:
"""Get Google Cloud access token for authentication."""
Expand Down