Make GetOperationTypeFromLoggingDevices respect just the device under consideration rather than all devices for a time log#271
Open
adv12 wants to merge 1 commit into
Conversation
… consideration rather than all devices for a time log. Signed-off-by: Andrew Vardeman <avardeman@agleader.com>
Contributor
|
@strhea Reviewed and tested. Recommend merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We received some Fendt data where a tractor was pulling a Capstan sprayer. There was machine log data on the tractor device and spraying data on the sprayer. In SMS, we merge machine log OperationDatas with other logged data from the same Operation, but only if the machine log data comes in as Unknown or DataCollection from ADAPT. The overly-broad device searching in TimeLogMapper.GetOperationTypeFromLoggingDevices was causing all OperationDatas in the operation to come in as CropProtection, rather than some as CropProtection and some as Unknown/DataCollection. This PR restricts that search to only the device under consideration, so the tractor OperationDatas come in as Unknown rather than CropProtection.