Skip to content

Add parameters to function signatures to satisfy C23 strictness#529

Merged
Cuyler36 merged 4 commits into
ACreTeam:masterfrom
turtlekiosk:add-parameters-to-signatures
Apr 24, 2026
Merged

Add parameters to function signatures to satisfy C23 strictness#529
Cuyler36 merged 4 commits into
ACreTeam:masterfrom
turtlekiosk:add-parameters-to-signatures

Conversation

@turtlekiosk
Copy link
Copy Markdown
Contributor

@turtlekiosk turtlekiosk commented Apr 24, 2026

There are functions with undeclared parameters in the signature that are passed in at the function call sites. This PR changes the function signatures to declare these parameters.

There is one function aHT1_GetDefaultAngle() that is called both with and without a parameter. A macro is used to satisfy both codewarrior and clang compilers.

@decomp-dev
Copy link
Copy Markdown

decomp-dev Bot commented Apr 24, 2026

Report for GAFE01_00 (c6d5d8f - 7f5cc03)

No changes

Copy link
Copy Markdown
Collaborator

@Cuyler36 Cuyler36 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good other than the aHT1_GetDefaultAngle issue.

Comment thread src/actor/npc/ac_harvest_npc1.c Outdated
@Cuyler36 Cuyler36 merged commit 4ae9cbc into ACreTeam:master Apr 24, 2026
@turtlekiosk turtlekiosk deleted the add-parameters-to-signatures branch April 24, 2026 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants