Simplify and improve runSuspendTest#864
Open
pm47 wants to merge 3 commits into
Open
Conversation
The custom iOS test runner existed only to work around NativeSocket delivering its callbacks on the main GCD queue: it ran the test body on the main dispatcher and pumped the main run loop, which a plain runBlocking would have starved. Since the previous commit, callbacks are delivered on a dedicated queue, so the workaround is obsolete. The runBlocking actuals are now identical on all platforms and can be removed.
Report a test timeout as an assertion failure with an explicit message instead of a bare TimeoutCancellationException, whose Kotlin/Native stack trace points into the coroutines runtime and says nothing. On timeout, also cancel the test job and wait for its coroutines to complete their cleanup before failing: output printed after a test is reported finished is attributed to no running test, which can crash gradle's test listener (NullPointerException: "runningOp" is null).
sstone
requested changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #861.