[RFC] Allow to create and persist offers#743
Closed
vincenzopalazzo wants to merge 6 commits into
Closed
Conversation
Allow to push to maven local the artifact to be able to use dev version of the library. Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
Allow creating more offers with customizable amount and description.
Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
When we store offers, we should also restore the status of the offer manager when we are restarting the node implementation. Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
vincenzopalazzo
force-pushed
the
macros/custom-offer
branch
from
cca973c to
22560e1
Compare
4 tasks
Closed
Member
|
Superseded by #774, which removes the need to store custom offers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is my first version of the solution based on the @thomash-acinq PR to allow creating and making persistent offers that contain an amount and/or a description.
I would like to gain some feedback on the solution proposed and also on the Database interface to find possible optimization.
This is part of the discussion #729 (comment)
Based on #678
Build on top #742