Create Marsobs task to get conventional observations from MARS - #82
Open
pescribaa wants to merge 3 commits into
Open
Create Marsobs task to get conventional observations from MARS#82pescribaa wants to merge 3 commits into
pescribaa wants to merge 3 commits into
Conversation
…observations from MARS within the tactus suite
…observations from MARS within the tactus suite add new files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a draft PR. There is code that has to be cleaned/reorganized. Main points:
Task Marsobs has been created within the tactus DA suite. The references for this work have been the task Marsprep from tactus and the Harmonie MARS syntax to get the data. Currently an obs file with conventional observations is downloaded from MARS and stored in ob_dir
This is a first development that should be refined to integrate in a cleaner or more general way both Marsprep and Marsobs and associated functions. In particular marsobs.py should be cleaned/simplified, because there is a lot of code not used.
The main function that makes the work in marsobs.py is named get_observations.
Need to test Canari and Oopsvar work with this obs file. To do this is needed to give to the obs file a name and dir structure for ObsConvert to be able to read it.
Note: Although we are not doing any assimilation, I need to use te assimilation.toml config file for at least to use the da.ob_dir variable, which contains the path where the obs file will be stored.
Reviewers
I suggest @kastelecn and @trygveasp to review this PR