Draft
Fix spotbugs javadoc warnings in hadoop-azure module#158
Conversation
Co-authored-by: manika137 <80244229+manika137@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix Spotbugs issues by adding Javadocs
Fix spotbugs javadoc warnings in hadoop-azure module
Jan 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Addressed 18 spotbugs javadoc warnings across ABFS services and utilities. All public methods, constructors, and enum constants now have proper documentation.
Changes by component:
AbfsAclHelper.java): Added javadoc for 7 public static methods handling ACL deserialization, serialization, modification, and removal operationsAbfsHttpOperation.java,AbfsAHCHttpOperation.java): DocumentedgetResponseHeaders(), fixed main description forisConnectionDisconnectedOnError(), added constructor javadoc, replaced incorrect@inheritDocwith proper description forgetRequestProperty()AbfsBackoffMetrics.java,AbfsBackoffMetricsEnum.java): Added missing@paramfor constructor, documented 13 enum constants covering throttling, retry, and request metricsAbfsClient.java,AbfsBlobClient.java): Added main description forgetAbfsMetricsManager(), documented constructor and test helper methodsAbfsApacheHttpExpect100Exception.java): Documented constructorHow was this patch tested?
Code review and syntax validation. No functional changes require testing.
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?AI Tooling
If an AI tool was used:
https://www.apache.org/legal/generative-tooling.html
Contains content generated by GitHub Copilot.
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
repository.apache.org/usr/lib/jvm/temurin-17-jdk-amd64/bin/java /usr/lib/jvm/temurin-17-jdk-amd64/bin/java --enable-native-access=ALL-UNNAMED -classpath /usr/share/apache-maven-3.9.12/boot/plexus-classworlds-2.9.0.jar -Dclassworlds.conf=/usr/share/apache-maven-3.9.12/bin/m2.conf -Dmaven.home=/usr/share/apache-maven-3.9.12 -Dlibrary.jansi.path=/usr/share/apache-maven-3.9.12/lib/jansi-native -Dmaven.multiModuleProjectDirectory=/home/REDACTED/work/AbfsHadoop/AbfsHadoop/hadoop-tools/hadoop-azure org.codehaus.plexus.classworlds.launcher.Launcher javadoc:javadoc -DskipTests(dns block)repository.jboss.org/usr/lib/jvm/temurin-17-jdk-amd64/bin/java /usr/lib/jvm/temurin-17-jdk-amd64/bin/java --enable-native-access=ALL-UNNAMED -classpath /usr/share/apache-maven-3.9.12/boot/plexus-classworlds-2.9.0.jar -Dclassworlds.conf=/usr/share/apache-maven-3.9.12/bin/m2.conf -Dmaven.home=/usr/share/apache-maven-3.9.12 -Dlibrary.jansi.path=/usr/share/apache-maven-3.9.12/lib/jansi-native -Dmaven.multiModuleProjectDirectory=/home/REDACTED/work/AbfsHadoop/AbfsHadoop/hadoop-tools/hadoop-azure org.codehaus.plexus.classworlds.launcher.Launcher javadoc:javadoc -DskipTests(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
Create a new branch out of trunk and help me fix spotbug issues
Most of them are related to adding javadocs.
[ERROR] /home/jenkins/jenkins-agent/workspace/hadoop-multibranch_PR-8212/ubuntu-focal/src/hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsAclHelper.java:47: warning: no comment
[ERROR] public static Map<String, String> deserializeAclSpec(final String aclSpecString) throws AzureBlobFileSystemException {
[ERROR] ^
[ERROR] /home/jenkins/jenkins-agent/workspace/hadoop-multibranch_PR-8212/ubuntu-focal/src/hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsAclHelper.java:189: warning: no comment
[ERROR] public static boolean isUpnFormatAclEntries(Map<String, String> aclEntries) {
[ERROR] ^
[ERROR] /home/jenkins/jenkins-agent/workspace/hadoop-multibranch_PR-8212/ubuntu-focal/src/hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsAclHelper.java:145: warning: no comment
[ERROR] public static void modifyAclEntriesInternal(Map<String, String> aclEntries, Map<String, String> toModifyEntries)
[ERROR] ^
[ERROR] /home/jenkins/jenkins-agent/workspace/hadoop-multibranch_PR-8212/ubuntu-focal/src/hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsAclHelper.java:73: warning: no comment
[ERROR] public static String processAclString(final String aclSpecString) {
[ERROR] ^
[ERROR] /home/jenkins/jenkins-agent/workspace/hadoop-multibranch_PR-8212/ubuntu-focal/src/hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsAclHelper.java:95: warning: no comment
[ERROR] public static void removeAclEntriesInternal(Map<String, String> aclEntries, Map<String, String> toRemoveEntries)
[ERROR] ^
[ERROR] /home/jenkins/jenkins-agent/workspace/hadoop-multibranch_PR-8212/ubuntu-focal/src/hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsAclHelper.java:62: warning: no comment
[ERROR] public static String serializeAclSpec(final Map<String, String> aclEntries) {
[ERROR] ^
[ERROR] /home/jenkins/jenkins-agent/workspace/hadoop-multibranch_PR-8212/ubuntu-focal/src/hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsAclHelper.java:170: warning: no comment
[ERROR] public static void setAclEntriesInternal(Map<String, String> aclEntries, Map<String, String> getAclEntries)
[ERROR] ^
[ERROR] Generating /home/jenkins/jenkins-agent/workspace/hadoop-multibranch_PR-8212/ubuntu-focal/src/hadoop-tools/hadoop-azure/target/site/apidocs/org/apache/hadoop/fs/azurebfs/services/AbfsAdaptiveInputStream.html...
[ERROR] Generating /home/jenkins/jenkins-agent/workspace/hadoop-multibranch_PR-8212/ubuntu-focal/src/hadoop-tools/hadoop-azure/target/site/apidocs/org/apache/hadoop/fs/azurebfs/services/AbfsAHCHttpOperation.html...
[ERROR] /home/jenkins/jenkins-agent/workspace/hadoop-multibranch_PR-8212/ubuntu-focal/src/hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsHttpOperation.java:690: warning: no main description
[ERROR] * @return value of {@link #connectionDisconnectedOnError}
[ERROR] ^
[ERROR] /home/jenkins/jenkins-agent/workspace/hadoop-multibranch_PR-8212/ubuntu-focal/src/hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsAHCHttpOperation.java:101: warning: no comment
[ERROR] public AbfsAHCHttpOperation(final URL url,
[ERROR] ^
[ERROR] /home/jenkins/jenkins-agent/workspace/hadoop-multibranch_PR-8212/ubuntu-focal/src/hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsAHCHttpOperation.java:425: warning: @inheritdoc used but getRequestProperty(String) does not override or implement any method.
[ERROR] public String getRequestProperty(String name) {
[ERROR] ^
[ERROR] /home/jenkins/jenkins-agent/workspace/hadoop-multibranch_PR-8212/ubuntu-focal/src/hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsHttpOperation.java:238: warning: no comment
[ERROR] public abstract Map<String, List> getResponseHeaders();
[ERROR] ^
[ERROR] /home/jenkins/jenkins-agent/workspace/hadoop-multibranch_PR-8212/ubuntu-focal/src/hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsAHCHttpOperation.java:425: warning: @inheritdoc used but getRequestProperty(String) does not override or implement any method.
[ERROR] public String getRequestProperty(String name) {
[ERROR] ^
[ERROR] Generating /home/jenkins/jenkins-agent/workspace/hadoop-multibranch_PR-8212/ubuntu-focal/src/hadoop-tools/hadoop-azure/target/site/apidocs/org/apache/hadoop/fs/azurebfs/contracts/exceptions/AbfsApacheHttpExpect100Exception.html...
[ERROR] /home/jenkins/jenki...
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.