Feature/ci pipeline#55
Open
gaurigupta0604 wants to merge 6 commits into
Open
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds a comprehensive CI pipeline using GitHub Actions for automated Android project builds and testing on every PR and push to main. The implementation includes code quality tools and coverage reporting to ensure consistent code standards.
- Added GitHub Actions workflows with build automation, unit testing, and code coverage using JaCoCo
- Configured Detekt for Kotlin code linting and quality checks
- Updated Gradle dependencies and plugin configurations to support the CI pipeline
Reviewed Changes
Copilot reviewed 5 out of 8 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/ci.yml | Comprehensive CI workflow with build, test, coverage, and linting steps |
| .github/workflows/android.yml | Basic Android build workflow |
| app/build.gradle.kts | Added JaCoCo plugin and coverage reporting configuration |
| settings.gradle.kts | Reordered repository declarations for better resolution |
| gradle.properties | Removed hardcoded JDK path for better CI compatibility |
| pull_request: | ||
| branches: [ main ] | ||
| push: | ||
| branches: [ main, feature/ci-pipeline ] |
There was a problem hiding this comment.
The feature branch 'feature/ci-pipeline' should not be included in the push trigger for production CI. This should only include stable branches like 'main'.
Suggested change
| branches: [ main, feature/ci-pipeline ] | |
| branches: [ main ] |
Comment on lines
+16
to
+19
| uses: actions/checkout@v3 | ||
|
|
||
| - name: Set up JDK | ||
| uses: actions/setup-java@v3 |
There was a problem hiding this comment.
This workflow uses outdated action versions (checkout@v3, setup-java@v3) while ci.yml uses newer versions (v4). Consider updating to match the newer workflow or removing this duplicate workflow entirely.
Suggested change
| uses: actions/checkout@v3 | |
| - name: Set up JDK | |
| uses: actions/setup-java@v3 | |
| uses: actions/checkout@v4 | |
| - name: Set up JDK | |
| uses: actions/setup-java@v4 |
Comment on lines
+46
to
+54
| - name: Run Detekt (Kotlin Linter) | ||
| run: ./gradlew detekt | ||
|
|
||
| - name: Upload Detekt Report | ||
| if: always() | ||
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: detekt-report | ||
| path: build/reports/detekt |
There was a problem hiding this comment.
The detekt task is being executed without the detekt plugin being configured in the build.gradle.kts file. This will cause the CI to fail as the task doesn't exist.
Suggested change
| - name: Run Detekt (Kotlin Linter) | |
| run: ./gradlew detekt | |
| - name: Upload Detekt Report | |
| if: always() | |
| uses: actions/upload-artifact@v4 | |
| with: | |
| name: detekt-report | |
| path: build/reports/detekt | |
| # Detekt steps removed because the Detekt plugin is not configured in build.gradle.kts. |
Comment on lines
+140
to
+150
| val debugTree = fileTree("${buildDir}/intermediates/javac/debug/classes") { | ||
| exclude(fileFilter) | ||
| } | ||
|
|
||
| val kotlinDebugTree = fileTree("${buildDir}/tmp/kotlin-classes/debug") { | ||
| exclude(fileFilter) | ||
| } | ||
|
|
||
| classDirectories.setFrom(files(debugTree, kotlinDebugTree)) | ||
| sourceDirectories.setFrom(files("src/main/java", "src/main/kotlin")) | ||
| executionData.setFrom(fileTree(buildDir) { |
There was a problem hiding this comment.
Using deprecated 'buildDir' property. Should use 'layout.buildDirectory.get().asFile' instead for Gradle 7+ compatibility.
Suggested change
| val debugTree = fileTree("${buildDir}/intermediates/javac/debug/classes") { | |
| exclude(fileFilter) | |
| } | |
| val kotlinDebugTree = fileTree("${buildDir}/tmp/kotlin-classes/debug") { | |
| exclude(fileFilter) | |
| } | |
| classDirectories.setFrom(files(debugTree, kotlinDebugTree)) | |
| sourceDirectories.setFrom(files("src/main/java", "src/main/kotlin")) | |
| executionData.setFrom(fileTree(buildDir) { | |
| val debugTree = fileTree(layout.buildDirectory.get().asFile.resolve("intermediates/javac/debug/classes")) { | |
| exclude(fileFilter) | |
| } | |
| val kotlinDebugTree = fileTree(layout.buildDirectory.get().asFile.resolve("tmp/kotlin-classes/debug")) { | |
| exclude(fileFilter) | |
| } | |
| classDirectories.setFrom(files(debugTree, kotlinDebugTree)) | |
| sourceDirectories.setFrom(files("src/main/java", "src/main/kotlin")) | |
| executionData.setFrom(fileTree(layout.buildDirectory.get().asFile) { |
Comment on lines
+140
to
+150
| val debugTree = fileTree("${buildDir}/intermediates/javac/debug/classes") { | ||
| exclude(fileFilter) | ||
| } | ||
|
|
||
| val kotlinDebugTree = fileTree("${buildDir}/tmp/kotlin-classes/debug") { | ||
| exclude(fileFilter) | ||
| } | ||
|
|
||
| classDirectories.setFrom(files(debugTree, kotlinDebugTree)) | ||
| sourceDirectories.setFrom(files("src/main/java", "src/main/kotlin")) | ||
| executionData.setFrom(fileTree(buildDir) { |
There was a problem hiding this comment.
Using deprecated 'buildDir' property. Should use 'layout.buildDirectory.get().asFile' instead for Gradle 7+ compatibility.
Suggested change
| val debugTree = fileTree("${buildDir}/intermediates/javac/debug/classes") { | |
| exclude(fileFilter) | |
| } | |
| val kotlinDebugTree = fileTree("${buildDir}/tmp/kotlin-classes/debug") { | |
| exclude(fileFilter) | |
| } | |
| classDirectories.setFrom(files(debugTree, kotlinDebugTree)) | |
| sourceDirectories.setFrom(files("src/main/java", "src/main/kotlin")) | |
| executionData.setFrom(fileTree(buildDir) { | |
| val debugTree = fileTree("${layout.buildDirectory.get().asFile}/intermediates/javac/debug/classes") { | |
| exclude(fileFilter) | |
| } | |
| val kotlinDebugTree = fileTree("${layout.buildDirectory.get().asFile}/tmp/kotlin-classes/debug") { | |
| exclude(fileFilter) | |
| } | |
| classDirectories.setFrom(files(debugTree, kotlinDebugTree)) | |
| sourceDirectories.setFrom(files("src/main/java", "src/main/kotlin")) | |
| executionData.setFrom(fileTree(layout.buildDirectory.get().asFile) { |
Comment on lines
+140
to
+150
| val debugTree = fileTree("${buildDir}/intermediates/javac/debug/classes") { | ||
| exclude(fileFilter) | ||
| } | ||
|
|
||
| val kotlinDebugTree = fileTree("${buildDir}/tmp/kotlin-classes/debug") { | ||
| exclude(fileFilter) | ||
| } | ||
|
|
||
| classDirectories.setFrom(files(debugTree, kotlinDebugTree)) | ||
| sourceDirectories.setFrom(files("src/main/java", "src/main/kotlin")) | ||
| executionData.setFrom(fileTree(buildDir) { |
There was a problem hiding this comment.
Using deprecated 'buildDir' property. Should use 'layout.buildDirectory.get().asFile' instead for Gradle 7+ compatibility.
Suggested change
| val debugTree = fileTree("${buildDir}/intermediates/javac/debug/classes") { | |
| exclude(fileFilter) | |
| } | |
| val kotlinDebugTree = fileTree("${buildDir}/tmp/kotlin-classes/debug") { | |
| exclude(fileFilter) | |
| } | |
| classDirectories.setFrom(files(debugTree, kotlinDebugTree)) | |
| sourceDirectories.setFrom(files("src/main/java", "src/main/kotlin")) | |
| executionData.setFrom(fileTree(buildDir) { | |
| val debugTree = fileTree("${layout.buildDirectory.get().asFile}/intermediates/javac/debug/classes") { | |
| exclude(fileFilter) | |
| } | |
| val kotlinDebugTree = fileTree("${layout.buildDirectory.get().asFile}/tmp/kotlin-classes/debug") { | |
| exclude(fileFilter) | |
| } | |
| classDirectories.setFrom(files(debugTree, kotlinDebugTree)) | |
| sourceDirectories.setFrom(files("src/main/java", "src/main/kotlin")) | |
| executionData.setFrom(fileTree(layout.buildDirectory.get().asFile) { |
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: detekt-report | ||
| path: build/reports/detekt |
There was a problem hiding this comment.
The detekt reports path should likely be 'app/build/reports/detekt' to match the project structure, as detekt would run on the app module.
Suggested change
| path: build/reports/detekt | |
| path: app/build/reports/detekt |
Owner
|
@gaurigupta0604 kindly check into this suggestions by @copilot |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a CI pipeline using GitHub Actions for the Android project. The goal is to automate the build and testing process so that it runs on every PR and push to
main.What's been added:
assembleDebug)testDebugUnitTest)Let me know if there's anything I missed or should change. :)