Implemented Voice Controlled Device by gaurav123-4 · Pull Request #50 · A-Akhil/Astra-Ai

gaurav123-4 · 2025-07-26T14:56:26Z

Navdeep-lab · 2025-07-28T13:20:00Z

@gaurav123-4 ...did you check all the bugs? and can you please send me the output you are obtaining so i can proceed with merging

gaurav123-4 · 2025-07-28T19:48:53Z

@gaurav123-4 ...did you check all the bugs? and can you please send me the output you are obtaining so i can proceed with merging

yes there are no bugs .i will provide you the output

gaurav123-4 · 2025-07-28T20:52:02Z

Output-> Task :app:assembleDebug
BUILD SUCCESSFUL in 15s
30 actionable tasks: 30 executed

Performing Streamed Install
Success

How to Check Voice Control Is Working
After launching the app:

Tap the microphone or command button (if available).

Speak a prompt like “What’s the weather today?” or “Schedule a meeting.”

You should see:

Transcribed input

AI-generated response on screen

gaurav123-4 · 2025-07-29T21:54:55Z

Issue #23 Please check

Copilot

Pull Request Overview

This PR implements voice-controlled device management functionality for the AI Secretary app, enabling users to control system settings like brightness, volume, WiFi, and Bluetooth through voice commands.

Adds comprehensive device control system with voice command processing
Implements permission management for system-level access
Creates settings UI for device control configuration

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 8 comments.

Show a summary per file

File	Description
DeviceControlSettingsFragment.kt	New settings fragment for configuring device control permissions and features
ChatViewModel.kt	Integrates device control processing into chat flow and adds device status monitoring
AppModule.kt	Adds dependency injection for device control components
SettingsManager.kt	Adds preferences for device control settings
MemoryManager.kt	Adds device control command pattern recognition
DeviceVoiceProcessor.kt	Processes voice commands for device operations
DeviceStatusMonitor.kt	Monitors and reports device status
DevicePermissionManager.kt	Manages device control permissions
DeviceControlManager.kt	Core device control operations
AndroidManifest.xml	Adds required permissions for device control

Comments suppressed due to low confidence (2)

app/src/main/kotlin/com/example/aisecretary/ui/chat/ChatViewModel.kt:182

DeviceControlManager is created in multiple places (here and in DeviceVoiceProcessor). Consider storing it as a class property to avoid multiple instances and ensure consistency.

app/src/main/kotlin/com/example/aisecretary/ai/device/DevicePermissionManager.kt:28

The WRITE_SETTINGS permission in AndroidManifest.xml has maxSdkVersion="22" which conflicts with the runtime check for Build.VERSION.SDK_INT >= Build.VERSION_CODES.M (API 23+). This could cause permission issues on newer devices.

     * Check if WRITE_SETTINGS permission is granted

Copilot · 2025-08-04T05:27:19Z

+    // Device control components
+    private val deviceVoiceProcessor = AppModule.provideDeviceVoiceProcessor(getApplication())
+    private val devicePermissionManager = AppModule.provideDevicePermissionManager(getApplication())
+    private val deviceStatusMonitor = DeviceStatusMonitor(getApplication())


The deviceStatusMonitor is instantiated directly instead of using dependency injection like other components. Consider using AppModule.provideDeviceStatusMonitor() for consistency.

Suggested change

private val deviceStatusMonitor = DeviceStatusMonitor(getApplication())

private val deviceStatusMonitor = AppModule.provideDeviceStatusMonitor(getApplication())

Copilot · 2025-08-04T05:27:19Z

+class DeviceVoiceProcessor(private val context: Context) {
+
+    private val deviceControlManager = DeviceControlManager(context)
+


DeviceControlManager is instantiated directly instead of using the provided AppModule method. This creates inconsistency with other parts of the codebase that use dependency injection.

Suggested change

class DeviceVoiceProcessor(private val context: Context) {

private val deviceControlManager = DeviceControlManager(context)

class DeviceVoiceProcessor(

private val context: Context,

private val deviceControlManager: DeviceControlManager

) {

Copilot · 2025-08-04T05:27:20Z

+class DeviceStatusMonitor(private val context: Context) {
+
+    private val deviceControlManager = DeviceControlManager(context)


DeviceControlManager is instantiated directly instead of using the provided AppModule method. This creates inconsistency with dependency injection patterns used elsewhere.

Suggested change

class DeviceStatusMonitor(private val context: Context) {

private val deviceControlManager = DeviceControlManager(context)

class DeviceStatusMonitor(

private val context: Context,

private val deviceControlManager: DeviceControlManager

) {

Copilot · 2025-08-04T05:27:20Z

+    private val _bluetoothStatus = MutableStateFlow(DeviceStatus.Bluetooth(isBluetoothEnabled()))
+
+    // Combined status flow
+    val deviceStatus: StateFlow<DeviceStatusSummary> = combine(


The combine operation creates a new StateFlow that recalculates whenever any of the component flows change. Consider adding a debounce or throttle mechanism to prevent excessive updates when multiple device states change rapidly.

Copilot · 2025-08-04T05:27:20Z

+    /**
+     * Log audit event for security tracking
+     */
+    private fun logAuditEvent(action: String, details: String) {


The audit log is stored in plain text in internal storage without encryption. Consider encrypting sensitive audit information to protect user privacy.

Copilot · 2025-08-04T05:27:21Z

+            if (bluetoothAdapter == null) {
+                return DeviceControlResult.Error("Bluetooth not available on this device")
+            }
+


Bluetooth enable/disable operations should check for appropriate permissions (BLUETOOTH_CONNECT on API 31+) before executing to prevent SecurityExceptions.

Suggested change

// Check BLUETOOTH_CONNECT permission on API 31+

if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.S) {

val permission = android.Manifest.permission.BLUETOOTH_CONNECT

val hasPermission = ContextCompat.checkSelfPermission(context, permission) == PackageManager.PERMISSION_GRANTED

if (!hasPermission) {

return DeviceControlResult.Error("Missing BLUETOOTH_CONNECT permission. Please grant permission to control Bluetooth.")

}

}

Copilot · 2025-08-04T05:27:21Z

+        val instructions = devicePermissionManager.getPermissionRequestInstructions(permission)
+
+        val message = "$explanation\n\n$instructions"
+        Toast.makeText(requireContext(), message, Toast.LENGTH_LONG).show()


[nitpick] Using Toast for permission instructions may not provide the best user experience. Consider using a custom dialog or bottom sheet for better visibility and user interaction.

Suggested change

Toast.makeText(requireContext(), message, Toast.LENGTH_LONG).show()

AlertDialog.Builder(requireContext())

.setTitle("Permission Instructions")

.setMessage(message)

.setPositiveButton("OK", null)

.show()

Copilot · 2025-08-04T05:27:21Z

+                // For Android 10+, we need to guide user to system settings
+                return DeviceControlResult.RequiresUserAction(
+                    "Please enable/disable WiFi manually in system settings",
+                    Intent(Settings.ACTION_WIFI_SETTINGS)
+                )
+            }
+


The deprecated setWifiEnabled method is used without checking if it's supported. For Android 10+, this method is deprecated and may not work. The code handles this with a version check but could be clearer about the limitation.

Suggested change

// For Android 10+, we need to guide user to system settings

return DeviceControlResult.RequiresUserAction(

"Please enable/disable WiFi manually in system settings",

Intent(Settings.ACTION_WIFI_SETTINGS)

)

}

// Programmatic WiFi enable/disable is not supported on Android 10+ (API 29+)

Log.w("DeviceControlManager", "setWifiEnabled: Programmatic WiFi control is not supported on Android 10+ (API 29+). Guiding user to system settings.")

return DeviceControlResult.RequiresUserAction(

"Please enable/disable WiFi manually in system settings",

Intent(Settings.ACTION_WIFI_SETTINGS)

)

}

// On Android 9 and below, programmatic WiFi control is allowed

A-Akhil · 2025-08-04T05:29:48Z

@AkshitTiwarii kindly review this comments by @copilot

Implemented Voice Controlled Device

008f899

A-Akhil requested a review from Copilot August 4, 2025 05:25

Copilot AI reviewed Aug 4, 2025

View reviewed changes

	private val deviceStatusMonitor = DeviceStatusMonitor(getApplication())
	private val deviceStatusMonitor = AppModule.provideDeviceStatusMonitor(getApplication())

		class DeviceVoiceProcessor(private val context: Context) {

		private val deviceControlManager = DeviceControlManager(context)

		class DeviceStatusMonitor(private val context: Context) {

		private val deviceControlManager = DeviceControlManager(context)

+            // Check BLUETOOTH_CONNECT permission on API 31+
+            if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.S) {
+                val permission = android.Manifest.permission.BLUETOOTH_CONNECT
+                val hasPermission = ContextCompat.checkSelfPermission(context, permission) == PackageManager.PERMISSION_GRANTED
+                if (!hasPermission) {
+                    return DeviceControlResult.Error("Missing BLUETOOTH_CONNECT permission. Please grant permission to control Bluetooth.")
+                }
+            }

-        Toast.makeText(requireContext(), message, Toast.LENGTH_LONG).show()
+        AlertDialog.Builder(requireContext())
+            .setTitle("Permission Instructions")
+            .setMessage(message)
+            .setPositiveButton("OK", null)
+            .show()

Conversation

gaurav123-4 commented Jul 26, 2025

Uh oh!

Navdeep-lab commented Jul 28, 2025

Uh oh!

gaurav123-4 commented Jul 28, 2025

Uh oh!

gaurav123-4 commented Jul 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gaurav123-4 commented Jul 29, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Aug 4, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 4, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 4, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 4, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 4, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 4, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 4, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 4, 2025

Choose a reason for hiding this comment

Uh oh!

A-Akhil commented Aug 4, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

gaurav123-4 commented Jul 28, 2025 •

edited

Loading