Skip to content

toggle option to prevent disconnected surfaces#3

Open
lsyeazell wants to merge 1 commit into
6849-2020:masterfrom
lsyeazell:connected-surface
Open

toggle option to prevent disconnected surfaces#3
lsyeazell wants to merge 1 commit into
6849-2020:masterfrom
lsyeazell:connected-surface

Conversation

@lsyeazell

Copy link
Copy Markdown

new feature as suggested by the coauthor problem

@edemaine

Copy link
Copy Markdown
Contributor

Thanks for working on this! I gave it a try, and have the following comments:

  1. I find the user interface unclear. The button seems to be labeled with what you'd transition to, as opposed to the current mode. Maybe a checkbox or toggle of some sort would be clearer?
  2. Actually, the software doesn't seem very consistent when allowing disconnection. Sometimes I get a disconnected piece, but sometimes it just ignores the fact that I've created a cycle of cuts (some of the cuts are ignored). So perhaps the new mode should be permanently on (and doesn't need a UI), at least until this is fixed?
  3. If the surface is already disconnected (from the other mode), then in the no-disconnect mode, I can't click anything. Ideally we'd just check whether the two faces being cut are otherwise connected, and allow it if so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants