docs: Error semantics docs updates - #109
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates documentation error semantics wording/formatting to improve readability in both the README and Sphinx docs.
Changes:
- Replaces double-hyphen punctuation with an em dash in “Design” wording.
- Adds clarifying inline comments to the README’s “Error semantics” code example.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| README.md | Adjusts design prose punctuation and clarifies error semantics example comments. |
| docs/index.rst | Mirrors the design prose punctuation update in Sphinx index docs. |
Comments suppressed due to low confidence (1)
README.md:166
- This wrapped comment leaves a trailing space at end-of-line (line 165). Reflowing it to a single line avoids EOL whitespace and keeps the example readable.
# raises ClientCacheNotFoundError b/c the specific client was not
# cached above
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (2)
README.md:162
- The comment line has trailing whitespace (likely failing whitespace-trimming hooks) and references "pseudo-code" even though this section shows concrete examples; also consider matching the actual call shown below (boto3.client).
# raises ClientCacheExistsError b/c client(**kwargs) already exists
# (from the pseudo-code above)
README.md:166
- This wrapped comment includes trailing whitespace and can be expressed as a single line for readability (and to avoid whitespace issues in Markdown code blocks).
# raises ClientCacheNotFoundError b/c the specific client was not
# cached above
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
README.md:166
- The line break in this comment splits the phrase “was not cached” across lines and changes the original meaning slightly (“cached above”). Consider rephrasing so the wrapped comment reads naturally and doesn’t depend on “above” wording.
# raises ClientCacheNotFoundError b/c the specific client was not
# cached above
|
|
||
| ```python | ||
| # raises ClientCacheExistsError b/c client(**kwargs) already exists | ||
| # (from the pseudo-code above) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All submissions
type(scope)!: summary)?typevalues in this repository:feat,fix,perf,refactor,docs,style,test,build,ci,chore,revert.fix(cache): add a new parameter to ClientCache.!before:(example:feat!: remove deprecated cache API).feat-> minor,fix/perf-> patch,!-> major).--no-verify|-nvarguments will not help you avoid the PR status checks!git commit, runpre-commit installandpre-commit install-hooksbeforehand.pre-commit run --all-files.Submission details
The following PR creates basic semantic updates to the error docs in the README for easier comprehension and legibility.