Conversation
jone
suggested changes
Nov 27, 2019
tinagerber
force-pushed
the
tg_plone5
branch
2 times, most recently
from
2fd4771 to
05596b0
Compare
djowett-ftw
reviewed
Nov 27, 2019
djowett-ftw
left a comment
djowett-ftw
left a comment
There was a problem hiding this comment.
Please correct me if I'm wrong - but I'm concerned that this JS will still end up in the legacy bundle in production - we are declaring Shim resources with "deps" and the JS does not all seem to follow the RequireJS module pattern IIUC.
I think it would be worth testing this in production mode?
jone
suggested changes
Nov 27, 2019
tinagerber
force-pushed
the
tg_plone5
branch
from
05596b0 to
fc15b1d
Compare
|
Just to note - this references collective.js.jqueryui which breaks with this issue for Plone 5 resources. This unmerged PR seems to be the fix collective/collective.js.jqueryui#38, but until it's merged we'll need the branch it references |
tinagerber
force-pushed
the
tg_plone5
branch
2 times, most recently
from
1ab1c40 to
d4d4a18
Compare
tinagerber
force-pushed
the
tg_plone5
branch
from
d4d4a18 to
4d5868b
Compare
maethu
approved these changes
Dec 16, 2019
maethu
left a comment
maethu
left a comment
Contributor
There was a problem hiding this comment.
I added a little fix and tested it with instance fg and instance console. It seems to work fine now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #52