Adding namespaces#14
Open
mbuechmann wants to merge 3 commits into
Open
Conversation
|
I have just started using this but I'm wondering if this wouldn't be better implemented as another matcher. i.e. with_namespace(NS) in the same manner as with_attribute and with_text are currently done? |
Author
|
That would indeed be better for the user. Unfortunately xpath expressions do not match when a namespace is left out. E.g. this spec doc = '<foo xmlns="bar"></foo>'
expect(doc).to have_xpath('/foo')would fail, because no namespace is given. So this spec doc = '<foo xmlns="bar"></foo>'
expect(doc).to have_xpath('/a:foo').with_namespace(:a => 'bar')still fails as the first matcher fails. I am not sure, but I do not think that it is possible to have one matcher modify another matcher. The second matcher had to inject the namespace into the first one. (aside from being a bit ugly) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support of namespaces is added to all matchers. Usage of namespaces os optional so that there are no breaking api changes. Specs and examples are included and namespaces are documented in the README.