Skip to content

Avoid bug prone code #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hazendaz merged 2 commits into from
Jun 25, 2026
Merged

Avoid bug prone code #200

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fae47f9
[test] Use proper equals check for junit
hazendaz Jun 25, 2026
98fc2a2
Avoid bug prone usage of enum 'ordinal'
hazendaz Jun 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion src/main/java/org/csveed/token/TokenState.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,16 @@ public enum TokenState {
* @return the token state
*/
public TokenState next() {
return values()[(ordinal() + 1) % 3];
switch (this) {
case RESET:
return START;
case START:
return PROCESSING;
case PROCESSING:
return RESET;
default:
throw new IllegalStateException("Unknown TokenState: " + this);
}
}

/**
Expand Down
2 changes: 1 addition & 1 deletion src/test/java/org/csveed/bean/conversion/BeanWrapperTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,7 +310,7 @@ void getBooleanObject() throws Exception {
@Test
void setBooleanObject() throws Exception {
beanWrapper.setProperty(properties.fromName(new Column("booleanObject")), "on");
assertEquals(Boolean.TRUE, bean.getBooleanObject());
assertTrue(bean.getBooleanObject());
}

/**
Expand Down
Loading