Skip to content

⚡ Optimize MicrotubuleTorus with InstancedMesh in QuantumScene.tsx#73

Open
jason420247 wants to merge 1 commit into
masterfrom
⚡-optimize-microtubule-torus-instanced-mesh-jules-8869576220010299790

Hidden character warning

The head ref may contain hidden characters: "\u26a1-optimize-microtubule-torus-instanced-mesh-jules-8869576220010299790"
Open

⚡ Optimize MicrotubuleTorus with InstancedMesh in QuantumScene.tsx#73
jason420247 wants to merge 1 commit into
masterfrom
⚡-optimize-microtubule-torus-instanced-mesh-jules-8869576220010299790

Conversation

@jason420247

Copy link
Copy Markdown
Collaborator

💡 What: Replaced individual <mesh> components in MicrotubuleTorus with a single <instancedMesh>. Implemented useFrame logic to update instance matrices using a reusable THREE.Object3D and cached positions in useMemo.

🎯 Why: Rendering thousands of individual meshes (360 + 720 = 1080) caused excessive draw calls, leading to poor performance. InstancedMesh allows rendering all instances in a single draw call per component.

📊 Measured Improvement:

  • Baseline (Estimated): ~1082 draw calls (1080 for meshes + ~2 for scene setup/lighting).
  • Optimized (Estimated): ~4 draw calls (2 for instanced meshes + ~2 for scene setup/lighting).
  • Theoretical Gain: ~99.6% reduction in draw calls.

PR created automatically by Jules for task 8869576220010299790 started by @jason420247

- Replaced individual mesh rendering with InstancedMesh.
- Implemented efficient matrix updates in useFrame using a reusable Object3D.
- Cached instance data with useMemo.
- Added key={count} to ensure proper remounting on count changes.
- Set frustumCulled={false} for stable visibility.

Co-authored-by: jason420247 <44763042+jason420247@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant