Add fetcher and add 6 books#35
Open
markpotocki wants to merge 4 commits into
Open
Conversation
* still need to convert to requried structure * dates can be wrong depending on version publication
*adds Snow Crash *adds Magic Bites *adds Redwall *adds Gulliver's Travels *adds The Hunger Games *adds Alice in Wonderland The published date will reflect the editions publication date, not the original
Member
|
@markpotocki great work on the fetcher. But it gets limited information about the books, and the publisher & publication dates are also incorrect. |
Contributor
Author
|
@niftytushar it should be possible to modify it to use those I will look at their API and modify it to work with those instead. Should be able to get those in by the end of today and I’ll update this PR |
Member
|
Awesome! Thanks you so much. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Fixes issue
Fixes #20 Fixes #18 Fixes #17 Fixes #10 Fixes #5 Fixes #4
Adds a fetcher written in go to grab book information using Google Books API. The fecther can be used by giving it a space delimited list of book titles to search for. It will grab the first result and save the information in JSON format.
Example Usage
./fetcher hunger-games alice-in-wonderlandSpaces in titles need to be separated by "-"
The json files for the remainder of the books have been generated using this. The publication dates are the dates the edition it is referencing came out not the original publication date.