Skip to content

Replace imports from sage.all in doctests#137

Merged
NathanDunfield merged 2 commits into
3-manifolds:masterfrom
passagemath:replace-sage.all-in-doctests
Jan 20, 2026
Merged

Replace imports from sage.all in doctests#137
NathanDunfield merged 2 commits into
3-manifolds:masterfrom
passagemath:replace-sage.all-in-doctests

Conversation

@mkoeppe

@mkoeppe mkoeppe commented Nov 24, 2025

Copy link
Copy Markdown
Contributor

@NathanDunfield

Copy link
Copy Markdown
Member

Sorry for the slow response. It looks like pi needs to be added to sage_helper for the doctests to pass. Could you do that and rebase to the latest release? I will then merge it assuming the tests pass.

@mkoeppe mkoeppe force-pushed the replace-sage.all-in-doctests branch from 8b9f47c to cc1b987 Compare January 19, 2026 23:17
@mkoeppe

mkoeppe commented Jan 19, 2026

Copy link
Copy Markdown
Contributor Author

I made a slightly different change, keeping imports from sage.symbolic separate from imports from sage_helper

@mkoeppe

mkoeppe commented Jan 19, 2026

Copy link
Copy Markdown
Contributor Author

The error AttributeError: module 'typing_extensions' has no attribute 'TypeAliasType'. Did you mean: 'TypeAlias'? appears to be unrelated.

@NathanDunfield NathanDunfield merged commit 3fc2919 into 3-manifolds:master Jan 20, 2026
14 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants