Skip to content

Fix banner reload while keyboard is active#145

Merged
2sem merged 1 commit into
mainfrom
fix/hide-banner-while-keyboard
Jul 9, 2026
Merged

Fix banner reload while keyboard is active#145
2sem merged 1 commit into
mainfrom
fix/hide-banner-while-keyboard

Conversation

@2sem

@2sem 2sem commented Jul 9, 2026

Copy link
Copy Markdown
Owner

Summary

  • Hide the banner ad while the input field is focused / keyboard is active
  • Prevent repeated banner remount/reload cycles during landscape keyboard layout changes
  • Applies through the shared banner view used by normal portrait and landscape layouts

User flow

flowchart TD
  A[Main screen] --> B[Focus input]
  B --> C[Keyboard appears]
  C --> D[Banner hidden]
  D --> E[No repeated banner ready reload loop]
  B --> F[Dismiss keyboard]
  F --> G[Banner can render again]
Loading

Verification

  • git diff --check
  • mise x -- tuist build
  • mise x -- tuist test

Notes

  • This is intentionally minimal: the existing isInputFocused focus state now gates bannerAd rendering.

Result

Simulator Screenshot - iPhone 11 Pro Max - 2026-07-09 at 13 49 13

@tuist

tuist Bot commented Jul 9, 2026

Copy link
Copy Markdown

🛠️ Tuist Run Report 🛠️

Tests 🧪

Scheme Status Cache hit rate Tests Skipped Ran Commit
talktrans-Workspace 0 % 10 0 10 b16437487

Builds 🔨

Scheme Status Duration Commit
talktrans-Workspace 1m 39s b16437487

@2sem 2sem force-pushed the fix/hide-banner-while-keyboard branch from dc5391f to a8490e0 Compare July 9, 2026 02:31
@2sem 2sem merged commit 97b0382 into main Jul 9, 2026
1 check passed
@2sem 2sem deleted the fix/hide-banner-while-keyboard branch July 9, 2026 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant