Fix search bar disappearing when no products match query#1
Open
285729101 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes antiwork#3262
The search bar and tables were conditionally rendered based on current
products.length, so when a search returned zero results the search bar would vanish and the table'suseEffect(which triggers Inertia reloads on query change) would stop running. The user gets stuck with no way to search again.The fix uses
useRefto remember whether products/memberships existed on initial page load. The search bar stays visible as long as there were initial items or there's an active query, and the table components stay mounted so their search effects keep firing. No changes needed in the table components themselves since their hooks run before the early return.Added a system test that searches for a nonexistent product, verifies the search bar persists, then clears the search and confirms products reappear.