More cleanup before removing Boost.Test

CMakePresets.json

@@ -123,6 +123,8 @@
       "displayName": "CI i686 Linux build",
       "errors": {"dev": true},
       "cacheVariables": {
+        "APPEND_CFLAGS": "-msse2 -mfpmath=sse",
+        "APPEND_CXXFLAGS": "-msse2 -mfpmath=sse",
         "APPEND_CPPFLAGS": "-DBOOST_MULTI_INDEX_ENABLE_SAFE_MODE",
         "BUILD_BENCH": "ON",
         "BUILD_CLI": "ON",

src/test/dbwrapper_tests.cpp

@@ -425,7 +425,7 @@ BOOST_AUTO_TEST_CASE(iterator_string_ordering)
                 for (int z = 0; z < y; ++z)
                     exp_key += exp_key;
                 StringContentsSerializer key;
-                uint32_t value;
+                uint32_t value{};
                 BOOST_CHECK(it->Valid());
                 if (!it->Valid()) // Avoid spurious errors about invalid iterator's key and value in case of failure
                     break;

src/test/result_tests.cpp

@@ -2,6 +2,7 @@
 // Distributed under the MIT software license, see the accompanying
 // file COPYING or http://www.opensource.org/licenses/mit-license.php.
 
+#include <memory.h>
 #include <util/result.h>
 
 #include <boost/test/unit_test.hpp>

src/test/settings_tests.cpp

@@ -146,9 +146,9 @@ BOOST_AUTO_TEST_CASE(NullOverride)
 {
     common::Settings settings;
     settings.command_line_options["name"].emplace_back("value");
-    BOOST_CHECK_EQUAL(R"("value")", GetSetting(settings, "section", "name", false, false, false).write().c_str());
+    BOOST_CHECK_EQUAL(R"("value")", GetSetting(settings, "section", "name", false, false, false).write());
     settings.forced_settings["name"] = {};
-    BOOST_CHECK_EQUAL(R"(null)", GetSetting(settings, "section", "name", false, false, false).write().c_str());
+    BOOST_CHECK_EQUAL(R"(null)", GetSetting(settings, "section", "name", false, false, false).write());
 }
 
 // Test different ways settings can be merged, and verify results. This test can

src/test/threadpool_tests.cpp

@@ -384,7 +384,7 @@ BOOST_AUTO_TEST_CASE(start_mid_stop_does_not_deadlock)
     try {
         threadPool.Start(NUM_WORKERS_DEFAULT);
     } catch (std::exception& e) {
-        BOOST_CHECK_EQUAL(e.what(), "Thread pool has been interrupted or is stopping");
+        BOOST_CHECK_EQUAL(std::string{e.what()}, "Thread pool has been interrupted or is stopping");
     }
     workers_blocker.release(NUM_WORKERS_DEFAULT);
     WAIT_FOR(blocking_tasks);