Add TxCollection#29
Draft
Sjors wants to merge 3 commits into
Draft
Conversation
Sjors
force-pushed
the
2026/07/tx-collection
branch
from
3f8107a to
e42dd57
Compare
Add Mining.collectTxs and the TxCollection capability to the capnp schema. TxCollection.makeTemplate takes an optional coinbase; when provided, Bitcoin Core validates the block with it instead of a node-generated dummy coinbase. Expand integration coverage to reject duplicate wtxids, observe missing transaction positions, provide a client-supplied transaction with addMissingTxs, build a template preserving the requested transaction order, and validate client-provided coinbases (used verbatim when valid; bad-cb-missing for a non-coinbase transaction; bad-cb-height for a wrong-height coinbase).
Sjors
force-pushed
the
2026/07/tx-collection
branch
from
e42dd57 to
26d1aad
Compare
Collaborator
Author
|
Rebased after #11:
|
Sjors
added a commit
to Sjors/sv2-apps
that referenced
this pull request
Jul 8, 2026
Point bitcoin_capnp_types_v32 at Sjors/bitcoin-capnp-types 2026/07/tx-collection (2140-dev/bitcoin-capnp-types#29), which adds the capnp bindings for the TxCollection interface introduced by bitcoin/bitcoin#35671. Revert to the 2140-dev repository (or a crates.io release) once that PR is merged.
Sjors
added a commit
to Sjors/sv2-apps
that referenced
this pull request
Jul 8, 2026
Instead of stubbing the v32 binary, build Bitcoin Core from the bitcoin/bitcoin#35671 (TxCollection) PR branch in the Integration Tests workflow, with ccache to keep warm-cache runs fast. This follows the approach used by 2140-dev/bitcoin-capnp-types#29. Remove once an official Bitcoin Core release ships TxCollection.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the
TxCollectionintroduced by bitcoin/bitcoin#35671.To be merged after: