Fix RP ID domain validation to require dot boundary#92
Merged
Conversation
The `ends_with()` check allowed attacker-controlled origins like `evil-example.com` to pass validation for RP ID `example.com`. This violates the W3C "is a registrable domain suffix of or is equal to" algorithm which requires a dot-prefixed suffix match. Replaced all three occurrences with a proper check that requires either an exact match or a dot-separated suffix.
Vogeltak
force-pushed
the
max/fix-rp-id-suffix-validation
branch
from
b2984e6 to
6f7936d
Compare
Progdrasil
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
ends_with()check allowed attacker-controlled origins likeevil-example.comto pass validation for RP IDexample.com. This violates the W3C "is a registrable domain suffix of or is equal to" algorithm which requires a dot-prefixed suffix match. Replaced all three occurrences with a proper check that requires either an exact match or a dot-separated suffix.