fix: get ESLint running and address low risk violations#136
Merged
Conversation
JillRegan
commented
May 19, 2026
JillRegan
commented
May 19, 2026
JillRegan
commented
May 19, 2026
bertrmz
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The repo's ESLint config file was named
.estlintrc.yml(est instead of esl), so ESLint silently used no config andnpm run lintexited 0 against any state of the codebase. Thelintscript in package.json was also missing a target path. After repairing both, lint surfaced 525 violations that had accumulated over the years. This PR addresses the low risk ones while documenting the remaining disabled rules with TODO comments. A follow-up ticket has been created to address the rest.Changes in this PR
.estlintrc.yml->.eslintrc.yml.srcand__test__.plugin:no-unsanitized/DOM→plugin:no-unsanitized/recommended-legacy.@typescript-eslint/tslint/configinline disable comments left over from the old TSLint migration. The plugin isn't installed, so each reference was emitting "Definition for rule not found" errors.Security fix:
typescript-eslint/parserandtypescript-eslint/eslint-pluginfrom 6.21.0 to ^8.0.0. Which pulls in a non vulnerable minimatch.eslint-plugin-deprecationits deps cap attypescript-eslintv7 and the functionality is now built intotypescript-eslintv8 astypescript-eslint/no-deprecated