Exit configure script on incorrect java version in JAVA_HOME - #63
Open
amwilkins wants to merge 1 commit into
Open
Exit configure script on incorrect java version in JAVA_HOME#63amwilkins wants to merge 1 commit into
amwilkins wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the Configure_Linux.sh script exits with an error message on any failed checks, except when checking the java version in the JAVA_HOME variable. On this check the script will show an error message, then continue to Miniconda3 installation, hiding the error message. The script can then end with a message "all checks passed -- YOU ARE GOOD", despite the JAVA_HOME variable not being set correctly.
This commit adds an "exit" command to that check so that the script fails after the error message is sent, and won't continue until the variable is set correctly.