initial gcp docs#993
Conversation
haberkornsam
requested review from
Chr1st0ph3rTurn3r and
MichaelBaj
as code owners
There was a problem hiding this comment.
Pull request overview
Adds initial BYOL installation documentation for deploying Session Smart Router (SSR) in GCP, and updates navigation to surface the new GCP (and AWS BYOL) guides.
Changes:
- Update
sidebars.jsto include new BYOL install docs for AWS and add a new “Installing In GCP” section. - Add new GCP BYOL deployment guides for Conductor-managed and Mist-managed SSR.
- Add new AWS BYOL deployment guides for Conductor-managed and Mist-managed SSR, plus a small Azure wording correction.
Reviewed changes
Copilot reviewed 4 out of 6 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| sidebars.js | Renames AWS BYOL doc IDs and adds a new GCP install category in the sidebar. |
| docs/intro_installation_byol_gcp_mist.md | New guide for deploying a BYOL Mist-managed SSR in GCP. |
| docs/intro_installation_byol_gcp_conductor.md | New guide for deploying a BYOL Conductor and Conductor-managed SSR in GCP. |
| docs/intro_installation_byol_azure_mist.md | Corrects an Azure-specific wording issue in the intro. |
| docs/intro_installation_byol_aws_mist.md | New guide for deploying a BYOL Mist-managed SSR in AWS. |
| docs/intro_installation_byol_aws_conductor.md | New guide for deploying a BYOL Conductor and Conductor-managed SSR in AWS. |
|
|
||
| The following instance types are supported for virtual SSR in GCP. Choose the size that best meets your requirements. More information can be found in the [GCP Documentation](https://docs.cloud.google.com/compute/docs/compute-optimized-machines#c2_machine_types). | ||
|
|
||
| | Recommended VM Size | Max vNICs Supported | vCPU Cores | Memory | |
There was a problem hiding this comment.
Similar to my sizing comment from before, since we don't have router sizing on our docs site, perhaps provide another column with the equivalent SSR product? (e.g., SSR120, SSR130, etc.)
There was a problem hiding this comment.
I think this is a larger effort we need to do for all 3 clouds. @agrawalkaushik and I have talked about how we should do this.
There was a problem hiding this comment.
@haberkornsam my understanding is that we picked these instance types based on the SSR models, correct? Can we try to let copilot solve this for us? @MichaelBaj my one hesitation of adding this level of detail is that its not apples to apples - so we might want to be mindful of the wording.
to Sam's point - we would want to tackle that in a separate PR
Initial GCP docs
TODO: