Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions internal/runtime/events_subagent.go
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@ const (
EventSubAgentStarted EventType = "subagent_started"
// EventSubAgentProgress 在子代理执行每一步后触发。
EventSubAgentProgress EventType = "subagent_progress"
// EventSubAgentRetried 在子代理任务进入重试后触发。
EventSubAgentRetried EventType = "subagent_retried"
// EventSubAgentCompleted 在子代理成功结束后触发。
EventSubAgentCompleted EventType = "subagent_completed"
// EventSubAgentFailed 在子代理失败结束后触发。
Expand Down
17 changes: 16 additions & 1 deletion internal/runtime/subagent_run.go
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,22 @@ func (s *Service) RunSubAgentTask(ctx context.Context, input SubAgentTaskInput)
emitSubAgentProgress(s, input, stepResult, stepErr)

if stepErr != nil {
if errors.Is(stepErr, context.Canceled) || errors.Is(stepErr, context.DeadlineExceeded) {
if errors.Is(stepErr, context.DeadlineExceeded) {
_ = worker.Stop(subagent.StopReasonTimeout)
result, resultErr := worker.Result()
if resultErr != nil {
result = subagent.Result{
Role: input.Role,
TaskID: input.Task.ID,
State: subagent.StateFailed,
StopReason: subagent.StopReasonTimeout,
Error: errorText(stepErr),
}
}
emitSubAgentTerminal(s, ctx, input, result)
return result, stepErr
}
if errors.Is(stepErr, context.Canceled) {
_ = worker.Stop(subagent.StopReasonCanceled)
result, resultErr := worker.Result()
if resultErr != nil {
Expand Down
50 changes: 46 additions & 4 deletions internal/runtime/subagent_run_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ import (
"errors"
"strings"
"testing"
"time"

"neo-code/internal/runtime/controlplane"
"neo-code/internal/subagent"
Expand Down Expand Up @@ -182,6 +181,50 @@ func TestServiceRunSubAgentTaskFailureFlows(t *testing.T) {
})
})

t.Run("context deadline should emit failed timeout", func(t *testing.T) {
t.Parallel()

service := NewWithFactory(nil, nil, nil, nil, nil)
service.SetSubAgentFactory(stubSubAgentFactory{
create: func(role subagent.Role) (subagent.WorkerRuntime, error) {
return &stubSubAgentWorker{
current: subagent.StateRunning,
stepErr: context.DeadlineExceeded,
resultErr: errors.New("no result"),
result: subagent.Result{
Role: role,
TaskID: "task-timeout",
},
}, nil
},
})

result, err := service.RunSubAgentTask(context.Background(), SubAgentTaskInput{
RunID: "sub-run-timeout-emit",
Role: subagent.RoleReviewer,
Task: subagent.Task{
ID: "task-timeout",
Goal: "review",
},
})
if err == nil || !errors.Is(err, context.DeadlineExceeded) {
t.Fatalf("error = %v, want context deadline exceeded", err)
}
if result.State != subagent.StateFailed {
t.Fatalf("result state = %q, want %q", result.State, subagent.StateFailed)
}
if result.StopReason != subagent.StopReasonTimeout {
t.Fatalf("stop reason = %q, want %q", result.StopReason, subagent.StopReasonTimeout)
}

events := collectRuntimeEvents(service.Events())
assertEventSequence(t, events, []EventType{
EventSubAgentStarted,
EventSubAgentProgress,
EventSubAgentFailed,
})
})

t.Run("worker start failed by disallowed capability", func(t *testing.T) {
t.Parallel()

Expand Down Expand Up @@ -340,9 +383,8 @@ func TestServiceRunSubAgentTaskInputValidation(t *testing.T) {
t.Fatalf("expected invalid role error")
}

ctx, cancel := context.WithTimeout(context.Background(), time.Nanosecond)
defer cancel()
time.Sleep(2 * time.Millisecond)
ctx, cancel := context.WithCancel(context.Background())
cancel()
if _, err := service.RunSubAgentTask(ctx, SubAgentTaskInput{
RunID: "sub-run-timeout",
Role: subagent.RoleCoder,
Expand Down
Loading
Loading