feat(session): 增加 Todo 状态持久化与校验 by wynxing · Pull Request #280 · 1024XEngineer/neo-code

wynxing · 2026-04-14T03:31:06Z

背景

为 Session 增加结构化 Todo 状态，沿用现有 internal/session JSON 持久化链路，不引入新的存储子系统。

本次修改

在 internal/session 新增 TodoItem 和 TodoStatus
为 Session 增加 Todos []TodoItem 字段
在 Save/Load 路径中增加 Todo 的规范化和校验
支持旧 session 文件缺失 todos 字段时按空列表兼容加载
增加 Todo 基础 helper：
- FindTodo
- AddTodo
- UpdateTodoStatus
- DeleteTodo
删除 Todo 前增加反向依赖检查，返回更明确的错误信息
同步补充 session 持久化文档和 Todo 设计说明

校验规则

Todo 状态固定为：
- pending
- in_progress
- completed
拒绝空 id
拒绝空 content
拒绝重复 ID
拒绝自依赖
拒绝引用不存在的依赖项

测试

已通过：

go test ./internal/session/...
go test ./...

link #261

codecov · 2026-04-14T03:32:37Z

Codecov Report

❌ Patch coverage is 87.58170% with 19 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
internal/session/todo.go	86.61%	12 Missing and 7 partials ⚠️

📢 Thoughts on this report? Let us know!

wynxing · 2026-04-14T03:36:50Z

/simplify

fennoai · 2026-04-14T03:37:04Z

Completed

Checked historical review comments and identified unresolved items.
Fixed all worth-fixing unresolved comments: repaired garbled UTF-8 Chinese text in docs/session-persistence-design.md (todos section).
Ran a code-simplifier subagent pass and applied a behavior-preserving simplification in internal/session/todo.go:
- extracted shared ensureTodoID helper
- removed duplicated Todo ID trim/empty checks in FindTodo / UpdateTodoStatus / DeleteTodo
Added regression test TestSessionTodoHelpersRejectEmptyID in internal/session/todo_test.go.
Ran tests successfully:
- go test ./internal/session/...
- go test ./...
Committed and pushed to the existing PR branch (Yumiue:refix_br).

Commit

c3af8c4 fix(session): resolve todo doc garbling and simplify todo id validation

Not Done

No additional non-requested refactors were made.

View job run

- repair garbled UTF-8 text in session persistence todo section - extract ensureTodoID to reduce duplicated id normalization - add regression test for empty todo id behavior Generated with [codeagent](https://github.com/qbox/codeagent) Co-authored-by: Yumiue <188874804+Yumiue@users.noreply.github.com>

wynxing · 2026-04-14T03:44:17Z

/review

fennoai

已按代码质量、性能、安全性、文档一致性完成复核，提交 1 条建议修正项（非阻塞）。

fennoai · 2026-04-14T03:46:10Z

+				break
+			}
+		}
+	}


normalizeAndValidateTodos 在 len(items)==0 时返回 nil，会让 Save/Load 后 Session.Todos 在 nil 与 [] 之间切换。当前 NewWithWorkdir 初始化为 []TodoItem{}，且文档将 todos 描述为固定结构字段；该行为会带来语义不一致与序列化不稳定（omitempty 下字段可能被省略）。建议这里返回空切片（[]TodoItem{}）或在 Save/Load 层统一规范为空切片。

fennoai

基于当前 PR 头部提交完成审查。发现 1 个建议修复项（测试覆盖缺口），其余代码质量/性能/安全/文档一致性未见阻塞问题。

fennoai · 2026-04-14T03:46:25Z

+	}
+	if err := session.UpdateTodoStatus("todo-1", TodoStatus("paused")); err == nil || !strings.Contains(err.Error(), `invalid todo status`) {
+		t.Fatalf("expected invalid status error, got %v", err)
+	}


建议补一组 nil receiver 用例（(*Session)(nil).AddTodo/UpdateTodoStatus/DeleteTodo）。当前生产代码在对应分支返回错误，但测试未锁定这些保护分支，后续重构时容易回归为 panic 或错误信息漂移。

fennoai

Completed a focused review of the latest PR diff (quality, performance, security, and documentation accuracy).

No blocking issues found in the current revision.

fennoai · 2026-04-14T03:46:36Z

@@ -0,0 +1,47 @@
+# Session Todo 设计说明


Reviewed end-to-end against the current implementation in internal/session; no inconsistencies found here.

fennoai

Reviewed the latest PR diff at commit c3af8c451c1b1928f9750361ce80bb680762870f across code quality, performance, security, and documentation consistency.

No noteworthy issues found in the current patch set.

fennoai · 2026-04-14T03:46:53Z

@@ -51,6 +52,22 @@ NeoCode 当前使用本地 JSON 文件持久化会话，以保持实现简单、
 - `user_constraints`


Re-checked this section in the latest commit: the UTF-8 text is readable and aligned with the current Todo persistence behavior.

fennoai

已基于最新提交 c3af8c451c1b1928f9750361ce80bb680762870f 完成复审（代码质量、性能、安全、文档一致性）。

结论：未发现阻塞性问题；以下为 1 条可选一致性优化建议。

fennoai · 2026-04-14T03:47:32Z

+				break
+			}
+		}
+	}


normalizeAndValidateTodos 在空输入时返回 nil，会让 Session.Todos 在 nil/[] 之间切换。当前 NewWithWorkdir 初始化为 []TodoItem{}，如果希望持久化前后语义更稳定，可考虑统一规范为空切片。

Cai-Tang-www · 2026-04-14T04:53:41Z

@xgopilot 这个Pr完美的实现了issues/261吗

fennoai · 2026-04-14T04:53:51Z

结论

不算“完美实现” issue #261；当前 PR 只覆盖了其中一部分基础能力。

未覆盖或不满足的关键点

状态集合不完整：当前仅支持 pending/in_progress/completed（internal/session/todo.go:13-20），缺少 issue feat(todo): 在 Session 中引入结构化 Todo 状态并完成持久化 #261 要求的 blocked/failed/canceled。
缺少状态机迁移约束：UpdateTodoStatus 仅校验目标状态是否合法（internal/session/todo.go:88-119），没有实现 issue 要求的“按来源状态限制迁移、终态不可逆”。
数据模型不完整：TodoItem 仅有 ID/Content/Status/Dependencies/Priority/CreatedAt/UpdatedAt（internal/session/todo.go:23-31），缺少 issue 提到的 OwnerType/OwnerID/Acceptance/Artifacts/Revision 等字段，也没有 TodoVersion（internal/session/store.go:22-38）。
并发保护未实现：没有 expected_revision 校验与 revision 递增逻辑（代码与测试中均未出现该机制）。
依赖校验未做环检测：目前只做“自依赖 + 依赖存在性”校验（internal/session/todo.go:198-207），未实现 issue 要求的循环依赖（DAG）检测。
Helper 集不一致：已有 FindTodo/AddTodo/UpdateTodoStatus/DeleteTodo（internal/session/todo.go:49-155），但 issue 要求的 UpdateTodo/GetTodoByID/ListTodos/SetTodoStatus 组合未完整对齐。
测试矩阵未覆盖上述缺口：现有测试覆盖 round-trip、缺失字段兼容、基础校验（如 internal/session/store_test.go:772-937, internal/session/todo_test.go:9-187），但没有状态迁移矩阵、环检测、revision 冲突相关测试。

已覆盖的部分（仅限本 PR 范围）

Session 已持久化 Todos，并在 Save/Load 做规范化与校验（internal/session/store.go:85-90、internal/session/todo.go:178-231）。
缺失 todos 字段可兼容加载为空列表（internal/session/store_test.go:834-870）。
实现了基础增删改查与删除前依赖阻断（internal/session/todo.go:49-155）。

如果要达到 issue #261 的“完整验收标准”，还需要补齐上面 1-7 项。

View job run

feat(session): 增加 Todo 状态持久化与校验

3366a8e

This comment was marked as outdated.

Sign in to view

test(session): 补充 Todo 异常路径测试

c190263

fennoai Bot reviewed Apr 14, 2026

View reviewed changes

phantom5099 merged commit d4e108a into 1024XEngineer:main Apr 14, 2026
2 checks passed

fennoai Bot mentioned this pull request Apr 15, 2026

风险点计算 #313

Closed

		@@ -51,6 +52,22 @@ NeoCode 当前使用本地 JSON 文件持久化会话，以保持实现简单、
		- `user_constraints`

Uh oh!

Conversation

wynxing commented Apr 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

背景

本次修改

校验规则

测试

Uh oh!

codecov Bot commented Apr 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

wynxing commented Apr 14, 2026

Uh oh!

fennoai Bot commented Apr 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Completed

Commit

Not Done

Uh oh!

wynxing commented Apr 14, 2026

Uh oh!

fennoai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

fennoai Bot Apr 14, 2026

Choose a reason for hiding this comment

Uh oh!

fennoai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

fennoai Bot Apr 14, 2026

Choose a reason for hiding this comment

Uh oh!

fennoai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

fennoai Bot Apr 14, 2026

Choose a reason for hiding this comment

Uh oh!

fennoai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

fennoai Bot Apr 14, 2026

Choose a reason for hiding this comment

Uh oh!

fennoai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

fennoai Bot Apr 14, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Cai-Tang-www commented Apr 14, 2026

Uh oh!

fennoai Bot commented Apr 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

结论

未覆盖或不满足的关键点

已覆盖的部分（仅限本 PR 范围）

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

wynxing commented Apr 14, 2026 •

edited

Loading

codecov Bot commented Apr 14, 2026 •

edited

Loading

fennoai Bot commented Apr 14, 2026 •

edited

Loading

fennoai Bot commented Apr 14, 2026 •

edited

Loading