docs: align architecture entry with mainline implementation#223
docs: align architecture entry with mainline implementation#223fennoai[bot] wants to merge 4 commits into
Conversation
Generated with [codeagent](https://github.com/qbox/codeagent) Co-authored-by: Cai-Tang-www <106404101+Cai-Tang-www@users.noreply.github.com>
Generated with [codeagent](https://github.com/qbox/codeagent) Co-authored-by: Cai-Tang-www <106404101+Cai-Tang-www@users.noreply.github.com>
Generated with [codeagent](https://github.com/qbox/codeagent) Co-authored-by: Cai-Tang-www <106404101+Cai-Tang-www@users.noreply.github.com>
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
![fennoai[bot]](https://avatars.githubusercontent.com/in/1924301?s=60&v=4){kind=small}
|
|
||
| ### Gateway | ||
|
|
||
| 仓库已经为未来的跨进程客户端、HTTP / WebSocket 网关和远端 UI 预留了协议边界与设计空间，但当前默认主链路仍是 `TUI / CLI -> Runtime`，不会强制经过独立 Gateway。 |
There was a problem hiding this comment.
This section now reads as if the repository still has an existing Gateway boundary or protocol surface reserved in code, but this PR deletes internal/gateway entirely. That makes "已经预留了协议边界与设计空间" misleading as a statement about the current implementation. Please reword this as a future direction unless there is still a concrete abstraction in main that readers can inspect.
|
|
||
| > 2026-04-10 修复进展：`internal/gateway` 已按建议移除；待审批权限状态改为由 `runtime.Service` 实例持有；缺失 workspace sandbox 时会显式报错；关键交互事件开始在投递失败时返回错误。 | ||
|
|
||
| 但仓库中仍存在几类会直接拉低可维护性和演进效率的问题： |
There was a problem hiding this comment.
This document is internally contradictory after the new progress note on line 18. It says the gateway/global-state/sandbox/event issues were fixed, but then immediately switches back to present-tense wording (仍存在) and describes those same issues as current problems. Please either mark the rest of the file as historical review findings, or update the wording so readers do not come away thinking the fixes in this PR have not landed.
|
|
||
| ### Gateway | ||
|
|
||
| 仓库已经为未来的跨进程客户端、HTTP / WebSocket 网关和远端 UI 预留了协议边界与设计空间，但当前默认主链路仍是 `TUI / CLI -> Runtime`，不会强制经过独立 Gateway。 |
There was a problem hiding this comment.
这里写成“已经为未来…预留了协议边界与设计空间”会让读者以为仓库里仍保留了现成的 Gateway 扩展接口，但本 PR 同时删除了 internal/gateway 的全部代码。建议改成“规划中的扩展方向”，或明确说明当前仅有设计意图、尚无代码级预留。
|
|
||
| ### Gateway | ||
|
|
||
| 仓库已经为未来的跨进程客户端、HTTP / WebSocket 网关和远端 UI 预留了协议边界与设计空间，但当前默认主链路仍是 `TUI / CLI -> Runtime`，不会强制经过独立 Gateway。 |
There was a problem hiding this comment.
This sentence now overstates the current implementation. In the same PR we remove internal/gateway, so the repository no longer contains a concrete gateway/protocol boundary that readers can inspect or extend. Rephrase this as a future design direction instead of saying the boundary is already reserved in the codebase.
Generated with [codeagent](https://github.com/qbox/codeagent) Co-authored-by: Cai-Tang-www <106404101+Cai-Tang-www@users.noreply.github.com>
|
@xgopilot pr已更新，更新你的审查意见和comment |
Findings
Validation
|
|
好蠢。。 |
2 participants
Requested by @Cai-Tang-www
Summary
docs/architecture/README.mdthat describes the current mainline runtime path and clearly marks Gateway as a reserved extension rather than current factREADME.mddocumentation index to point at the new architecture entryinternal/tools/types.gothatWorkspacePlan == nilmeans no sandbox binding was attached, not that sandbox validation already passedValidation
go test ./...Notes
Cai-Tang-www/neo-codemain locally, but direct push to that fork was rejected by GitHub permissions. This PR carries the same mainline-aligned changes directly to the primary repository.