Skip to content

fix(tui): 分离执行活动并恢复输出区滚动 #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
minorcell merged 2 commits into from
Apr 2, 2026
Merged

fix(tui): 分离执行活动并恢复输出区滚动 #117

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
12a71cb
fix(tui): separate activity from transcript
creatang Apr 2, 2026
2e02fda
test(tui): cover activity preview and mouse scroll
creatang Apr 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions internal/tui/app.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ type App struct {
transcript viewport.Model
input textarea.Model
activeMessages []provider.Message
activities []activityEntry
fileCandidates []string
focus panel
width int
Expand Down
6 changes: 6 additions & 0 deletions internal/tui/commands.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,8 @@ const (
sidebarTitle = "Sessions"
sidebarFilterHint = "Type / to search"
sidebarOpenHint = "Enter to open"
activityTitle = "Activity"
activitySubtitle = "Latest execution events"

draftSessionTitle = "Draft"
emptyConversationText = "No conversation yet.\nAsk NeoCode to inspect or change code, or type /help to browse local commands."
Expand All @@ -61,8 +63,12 @@ const (

focusLabelSessions = "Sessions"
focusLabelTranscript = "Transcript"
focusLabelActivity = "Activity"
focusLabelComposer = "Composer"

activityPreviewEntries = 3

@minorcell minorcell Apr 2, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing documentation for magic numbers

These constants lack comments explaining their purpose and rationale.

Suggested fix:

// activityPreviewEntries is the number of recent activity entries shown in the preview panel
activityPreviewEntries = 3
// maxActivityEntries is the maximum number of activity entries retained in memory to prevent unbounded growth
maxActivityEntries     = 64

maxActivityEntries = 64

messageTagUser = "[ YOU ]"
messageTagAgent = "[ NEO ]"
messageTagTool = "[ TOOL ]"
Expand Down
Loading
Loading