feat(consilium): ticket-first loops — auto commitPrefix, ticket in MR body, require-ticket gate - #579
Merged
Merged
Conversation
… body, require-ticket gate The werush forge rejects any push whose commits lack a Jira issue key, so every develop round published nothing (branch intact locally, MR never opened) — and the ticket never reached the MR description. - Ticket intake (launchTicketReview) now sets the loop's commitPrefix to '<KEY>: ' automatically (ReviewLaunchPlan.commitPrefix threaded to the factory) — every coder commit subject and the Draft-PR/MR title carry the key, so issue-key push policies pass. - The Draft-PR/MR BODY gains a ticket provenance line (key + link), threaded from the loop's launch provenance through SdlcHandoffRequest into buildPrStatusBody. Display-only, sanitized. - New config pipeline.consiliumLoop.requireTicketRef (default false): when on, a MANUAL launch without a ticket key is refused with an actionable 400 (the dialog's Jira field feeds commitPrefix). - Cleanup: the titleLabel control-strip regex carried RAW control bytes (rg treated the file as binary) — replaced with \u escapes. vitest: 180 passed across dispatch/route/executor/fsm suites. tsc clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Проблема
Forge werush отклоняет push без Jira-ключа в каждом коммите → develop-раунды не публиковались (ветка локально цела, MR не открывался), а тикет не попадал в описание MR. Пользователь дал PDO-922 — в MR его не было.
Фикс
commitPrefixсам:launchTicketReview→ReviewLaunchPlan.commitPrefix = "<KEY>: "→ фабрика → каждый коммит кодера и тайтл MR несут ключ (механика commitPrefix уже существовала — теперь она заполняется).- Ticket: <KEY> — <url>в заголовкеbuildPrStatusBody, из launch-провенанса лупа (SdlcHandoffRequest.ticketRef). Санитизировано, display-only.commitPrefix).titleLabel(PR feat(intake): ADR-004 Block A — direct ticket intake, one MR per task #573) оказались сырые контрол-байты — rg считал файл бинарным; заменены на \u-эскейпы.Тесты
180 passed (dispatch/route/executor/fsm), tsc чистый. Новые кейсы: auto-prefix из тикета; 400 без ключа при включённом флаге; 201 с ключом.