fix: match current provider model aliases to capability scores#78
Merged
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR extends model name normalization to recognize current provider-specific vendor aliases so that several Cloudflare, Hugging Face, and NVIDIA catalog entries correctly map to existing benchmark capability scores, and adds regression tests to lock in the normalization behavior. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The growing alternation list in
_VENDOR_PREFIX_REis becoming harder to maintain; consider defining vendor/alias prefixes in a data structure (e.g., a list or mapping) and generating the regex from it so new providers/aliases can be added in a single place.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The growing alternation list in `_VENDOR_PREFIX_RE` is becoming harder to maintain; consider defining vendor/alias prefixes in a data structure (e.g., a list or mapping) and generating the regex from it so new providers/aliases can be added in a single place.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
pytest -q tests/test_capability.pypytest -qSummary by Sourcery
Align model name normalization with current provider-specific aliases so benchmark capabilities apply to the correct models.
Bug Fixes:
Enhancements:
Tests: