Simple Format Virtual Machine sfvm#151
Closed
simonlechner wants to merge 7 commits into
Closed
Conversation
simonlechner
force-pushed
the
simon/sfvm
branch
2 times, most recently
from
November 13, 2025 09:46
a36c819 to
c2dfb7b
Compare
Collaborator
Author
HerbertJordan
left a comment
Collaborator
There was a problem hiding this comment.
@simonlechner Before reviewing it, a conceptional question we should discuss: Do we need/want to duplicate the implementation of instructions, stacks, memory, keccak, and other common tools or would it be fine to reuse those?
simonlechner
force-pushed
the
simon/sfvm
branch
from
November 28, 2025 10:02
c2dfb7b to
41001a2
Compare
Codecov Report✅ All modified and coverable lines are covered by tests.
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
simonlechner
force-pushed
the
simon/sfvm
branch
from
November 28, 2025 10:26
41001a2 to
5c1fd00
Compare
HerbertJordan
requested changes
Dec 17, 2025
HerbertJordan
left a comment
Collaborator
There was a problem hiding this comment.
As discussed offline, this PR should be split into multiple, easier to review steps.
Collaborator
Author
|
This PR has been split into several smaller ones, now merged into main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This PR adds a new interpreter to tosca, the sfvm build on top of the lfvm and simplifies it significantly. No more super instructions, logging, statistics and most importantly no more long format.
To ensure correctness before merging into main:
This PR is structured into multiple commits, which should be reviewed one by one.