Skip to content

Print values in debug log in decimal and hex format#149

Merged
HerbertJordan merged 1 commit into
mainfrom
herbert/update_debug_log
Dec 16, 2025
Merged

Print values in debug log in decimal and hex format#149
HerbertJordan merged 1 commit into
mainfrom
herbert/update_debug_log

Conversation

@HerbertJordan

Copy link
Copy Markdown
Collaborator

This PR updates the debug log of the LFVM to print stack values in decimal and hex format.

When debugging values, in particular related to account addresses or block header fields, reference sources like RPC services encode data in hex format. Cross-referencing those values is made much easier if values are printed in both formats.

@HerbertJordan
HerbertJordan force-pushed the herbert/update_debug_log branch from 25d595e to 0fb781e Compare November 6, 2025 17:11
@HerbertJordan
HerbertJordan force-pushed the herbert/update_debug_log branch from 5ac6476 to de4cea2 Compare December 16, 2025 11:18
@HerbertJordan
HerbertJordan force-pushed the herbert/update_debug_log branch from de4cea2 to 7e39e4d Compare December 16, 2025 11:23
@HerbertJordan
HerbertJordan requested a review from facuMH December 16, 2025 11:23
@codecov

codecov Bot commented Dec 16, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

Files with missing lines Coverage Δ
go/interpreter/lfvm/instruction_logger.go 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@facuMH facuMH left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR modifies the instruction logger so that stack logs show values in both hex and decimal.

@HerbertJordan
HerbertJordan merged commit 5e1f0a8 into main Dec 16, 2025
2 checks passed
@HerbertJordan
HerbertJordan deleted the herbert/update_debug_log branch December 16, 2025 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants