Deploy priority registry in fake genesis and report as system contract#1082
Merged
Conversation
LorenzSchueler
force-pushed
the
lorenz/gbs-6
branch
from
July 22, 2026 13:48
1e830d9 to
4305284
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Deploys the Transaction Priority Registry into the fake JSON genesis when TransactionPriorities is enabled and exposes its address via the ethapi “system contracts” registry so clients can discover it at runtime.
Changes:
- Deploys
PriorityRegistryas a proxy + implementation pair inGenerateFakeJsonGenesiswhenupgrades.TransactionPrioritiesis enabled. - Adds
TRANSACTION_PRIORITY_REGISTRY_ADDRESStoactiveSystemContracts()when priorities are enabled. - Extends integration/unit tests to validate registry deployment in fake genesis and to ensure fork IDs / system-contract reporting varies with the priorities upgrade flag.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| integration/makefakegenesis/json.go | Adds fake-genesis deployment of the Priority Registry (proxy + implementation) gated by TransactionPriorities. |
| integration/makefakegenesis/json_test.go | Adds coverage ensuring registry contracts are only deployed when the corresponding upgrade is enabled and that proxy wiring is correct. |
| api/ethapi/config.go | Exposes the Priority Registry address as a discoverable system contract when enabled. |
| api/ethapi/config_test.go | Updates tests to account for the new upgrade flag in fork ID uniqueness and system-contract reporting. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
LuisPH3
previously approved these changes
Jul 23, 2026
LuisPH3
left a comment
Collaborator
There was a problem hiding this comment.
The PR adds the new registry to the fake net and updates rpc methods to publish the address
LorenzSchueler
force-pushed
the
lorenz/gbs-6
branch
from
July 23, 2026 15:05
4305284 to
adb2678
Compare
Codecov Report✅ All modified and coverable lines are covered by tests.
... and 8 files with indirect coverage changes 🚀 New features to boost your workflow:
|
simonlechner
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR deploys the priority registry in the fake genesis when the priorities feature is enables and report as it as a system contract.