Skip to content

Deploy priority registry in fake genesis and report as system contract#1082

Merged
LorenzSchueler merged 2 commits into
mainfrom
lorenz/gbs-6
Jul 24, 2026
Merged

Deploy priority registry in fake genesis and report as system contract#1082
LorenzSchueler merged 2 commits into
mainfrom
lorenz/gbs-6

Conversation

@LorenzSchueler

Copy link
Copy Markdown
Contributor

This PR deploys the priority registry in the fake genesis when the priorities feature is enables and report as it as a system contract.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Deploys the Transaction Priority Registry into the fake JSON genesis when TransactionPriorities is enabled and exposes its address via the ethapi “system contracts” registry so clients can discover it at runtime.

Changes:

  • Deploys PriorityRegistry as a proxy + implementation pair in GenerateFakeJsonGenesis when upgrades.TransactionPriorities is enabled.
  • Adds TRANSACTION_PRIORITY_REGISTRY_ADDRESS to activeSystemContracts() when priorities are enabled.
  • Extends integration/unit tests to validate registry deployment in fake genesis and to ensure fork IDs / system-contract reporting varies with the priorities upgrade flag.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
integration/makefakegenesis/json.go Adds fake-genesis deployment of the Priority Registry (proxy + implementation) gated by TransactionPriorities.
integration/makefakegenesis/json_test.go Adds coverage ensuring registry contracts are only deployed when the corresponding upgrade is enabled and that proxy wiring is correct.
api/ethapi/config.go Exposes the Priority Registry address as a discoverable system contract when enabled.
api/ethapi/config_test.go Updates tests to account for the new upgrade flag in fork ID uniqueness and system-contract reporting.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

LuisPH3
LuisPH3 previously approved these changes Jul 23, 2026

@LuisPH3 LuisPH3 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR adds the new registry to the fake net and updates rpc methods to publish the address

@codecov

codecov Bot commented Jul 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

Files with missing lines Coverage Δ
api/ethapi/config.go 90.24% <100.00%> (+0.50%) ⬆️
integration/makefakegenesis/json.go 95.04% <100.00%> (+0.51%) ⬆️

... and 8 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@LorenzSchueler
LorenzSchueler merged commit 1462e51 into main Jul 24, 2026
3 checks passed
@LorenzSchueler
LorenzSchueler deleted the lorenz/gbs-6 branch July 24, 2026 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants