Skip to content

Upgrade solhint linter#19

Merged
thaarok merged 1 commit into
mainfrom
jk/upgrade-lint
Jun 9, 2026
Merged

Upgrade solhint linter#19
thaarok merged 1 commit into
mainfrom
jk/upgrade-lint

Conversation

@thaarok

@thaarok thaarok commented Jun 9, 2026

Copy link
Copy Markdown
Contributor
  • Upgrade solhint to 6.2.1 (support custom errors in require)
  • Fix some minor issues reported by the new linter (++i more gas efficient than i++)
  • Disable some new checks introduced by the new linter (requiring too big changes in SFC):
    • ignore missing natspec (use-natspec)
    • ignore not using "indexed" in events (gas-indexed-events)
    • ignore using a <= b instead of more gas efficient a < b+1 (gas-strict-inequalities)

@thaarok
thaarok requested a review from jmpike June 9, 2026 14:20
@thaarok thaarok changed the title Upgrade linter Upgrade solhint linter Jun 9, 2026
@thaarok
thaarok merged commit c95144b into main Jun 9, 2026
2 checks passed
@thaarok
thaarok deleted the jk/upgrade-lint branch June 9, 2026 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jmpike jmpike jmpike approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@thaarok @jmpike