Poll network rules check until all nodes converge#265
Merged
Conversation
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the networkRules checker to tolerate per-node lag in applying rule updates by polling until all active nodes converge (or a timeout is hit), addressing flakiness caused by epoch-seal timing differences across nodes.
Changes:
- Add a default convergence timeout and polling loop to
networkRuleschecks (instead of a single snapshot). - Factor the original check logic into
checkOnceand repeatedly invoke it until success/timeout. - Add tests covering eventual convergence after lag and returning a mismatch after timeout.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| driver/checking/network_rules.go | Adds timeout-bounded polling for convergence and introduces checkOnce. |
| driver/checking/network_rules_test.go | Adds unit tests for convergence polling behavior and timeout behavior. |
LuisPH3
requested changes
Jul 20, 2026
LuisPH3
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
networkRulescheck took a single instantaneous snapshot of each node's applied rules. But a rules update applies per node at the epoch seal, andwaitForEpochonly waits for one (random) node to advance, so immediately afterward a slower node can still report the pre-update rules.