Avoid pushing null values into KVCachedFile cache#440
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR prevents KVCachedFile.Get from caching missing keys by returning early when the underlying KVFile.Get returns nil, and adds a test to ensure the cache remains unmodified on such misses.
Changes:
- Add an early return in
KVCachedFile.Getwhen the backing file returnsnil(unknown key). - Extend the existing “unknown key” test to assert the cache does not contain the key after the miss.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| go/backend/kv_file/kv_cached_file.go | Avoids caching absent values by returning immediately when the backing file returns nil. |
| go/backend/kv_file/kv_cached_file_test.go | Adds an assertion that a miss (Get returning nil) does not populate the cache. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests.
... and 2 files with indirect coverage changes 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, querying a value from the file in the kv_cached_file could result into pushing a null value into the cache if it was not present on the file.
This PR fixes it and adds a test for it