Skip to content

Add Ordered file#438

Merged
ihtefyw merged 6 commits into
mainfrom
luigi/ordered_file
Jul 24, 2026
Merged

Add Ordered file#438
ihtefyw merged 6 commits into
mainfrom
luigi/ordered_file

Conversation

@ihtefyw

@ihtefyw ihtefyw commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

This PR adds the OrderedFile, an array-like KVFile.
Values have a fixed size, and their position in the file is determined by their key (uint64) times the size of the stored value.

This will be used to implement caching for the MPT root list

@codecov

codecov Bot commented Jul 21, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 91.57895% with 8 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
go/backend/kv_file/ordered_file.go 91.57% 4 Missing and 4 partials ⚠️
Files with missing lines Coverage Δ
go/backend/kv_file/ordered_file.go 91.57% <91.57%> (ø)

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ihtefyw
ihtefyw force-pushed the luigi/kv-cached-file branch from afc24f8 to 670ae69 Compare July 22, 2026 07:30
@ihtefyw
ihtefyw force-pushed the luigi/ordered_file branch 3 times, most recently from e408190 to 004bb79 Compare July 22, 2026 11:31
Base automatically changed from luigi/kv-cached-file to main July 22, 2026 11:42
@ihtefyw
ihtefyw requested a review from HerbertJordan July 22, 2026 11:42
@ihtefyw
ihtefyw force-pushed the luigi/ordered_file branch 2 times, most recently from fb0780b to 780309c Compare July 23, 2026 13:40
@ihtefyw
ihtefyw force-pushed the luigi/ordered_file branch from 780309c to beb39b7 Compare July 23, 2026 13:55

@HerbertJordan HerbertJordan left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the implementation fits the intended use case. However, I remarked a few design issues that you might want to address. Please have a look.

Comment thread go/backend/kv_file/ordered_file.go
Comment thread go/backend/kv_file/ordered_file.go Outdated
Comment thread go/backend/kv_file/ordered_file.go
Comment thread go/backend/kv_file/ordered_file.go
Comment thread go/backend/kv_file/ordered_file_test.go
@ihtefyw
ihtefyw force-pushed the luigi/ordered_file branch from 9bcf7c5 to 77536f6 Compare July 24, 2026 11:11
@ihtefyw
ihtefyw merged commit 9c146e6 into main Jul 24, 2026
4 checks passed
@ihtefyw
ihtefyw deleted the luigi/ordered_file branch July 24, 2026 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants