Add Ordered file#438
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
... and 2 files with indirect coverage changes 🚀 New features to boost your workflow:
|
ihtefyw
force-pushed
the
luigi/kv-cached-file
branch
from
July 22, 2026 07:30
afc24f8 to
670ae69
Compare
ihtefyw
force-pushed
the
luigi/ordered_file
branch
3 times, most recently
from
July 22, 2026 11:31
e408190 to
004bb79
Compare
ihtefyw
force-pushed
the
luigi/ordered_file
branch
2 times, most recently
from
July 23, 2026 13:40
fb0780b to
780309c
Compare
ihtefyw
force-pushed
the
luigi/ordered_file
branch
from
July 23, 2026 13:55
780309c to
beb39b7
Compare
HerbertJordan
approved these changes
Jul 24, 2026
HerbertJordan
left a comment
Collaborator
There was a problem hiding this comment.
I think the implementation fits the intended use case. However, I remarked a few design issues that you might want to address. Please have a look.
ihtefyw
force-pushed
the
luigi/ordered_file
branch
from
July 24, 2026 11:11
9bcf7c5 to
77536f6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the
OrderedFile, an array-likeKVFile.Values have a fixed size, and their position in the file is determined by their key (uint64) times the size of the stored value.
This will be used to implement caching for the MPT root list