fix(executor): release substate iterator on early exit#242
Open
ibrahim1023 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
substateProvider.Runnow releases the substate iterator on every exit path, including upper-bound early exits and consumer errors.Previously, the iterator was only released when iteration naturally reached exhaustion. For normal bounded runs,
Runcan return as soon as it sees a transaction at or beyond the requested upper block bound. In that path, and in the consumer-error path, the iterator was left unreleased even though the iterator contract requiresRelease()after use.This change keeps the existing behavior of stopping at the exclusive upper bound, preserves consumer errors, and also surfaces iterator errors after release.
Fixes #241
Type of change
Testing
go test ./executor