Skip to content

Update carmen version + fix tests#237

Open
ihtefyw wants to merge 4 commits into
mainfrom
luigi/fix-carmen-tests
Open

Update carmen version + fix tests#237
ihtefyw wants to merge 4 commits into
mainfrom
luigi/fix-carmen-tests

Conversation

@ihtefyw

@ihtefyw ihtefyw commented May 13, 2026

Copy link
Copy Markdown
Contributor

This PR updates the Carmen submodule to 0xsoniclabs/carmen@0bc3727.

Some tests had to be fixed:

  • TestStateDbManager_OverrideArchiveVariant has been removed, as no other archive version to override are present
  • Default archive mode is now s5
  • Removed the sqlite and leveldb archive configurations and replaced with an s5 one
  • Substituted every entry of Carmen::CreateAccount with Carmen::AddBalance as Carmen does not expose CreateAccount anymore

Importantly, those changes are NOT required for carmen/sonic_2.2 release branch, therefore Aida should not include those changes when targeting it

@ihtefyw
ihtefyw requested review from HerbertJordan and wsodsong May 13, 2026 08:50
@codecov

codecov Bot commented May 13, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

Files with missing lines Coverage Δ
state/carmen.go 85.88% <100.00%> (-0.23%) ⬇️
utils/test_cases.go 87.27% <100.00%> (-0.23%) ⬇️

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@HerbertJordan

Copy link
Copy Markdown
Contributor

@wsodsong fyi, this are already changes for the post 2.2.0 development. If you need Aida's main branch to remain 2.2.0 compatible, this PR should not be merged until this compatibility can be broken.

@wsodsong

Copy link
Copy Markdown
Contributor

@HerbertJordan Got it. I will keep this as PR until we have v2.2.0. Will this carmen change be part of rc.2?

wsodsong
wsodsong previously approved these changes May 22, 2026
HerbertJordan
HerbertJordan previously approved these changes May 26, 2026
@ihtefyw
ihtefyw dismissed stale reviews from HerbertJordan and wsodsong via 8088933 May 28, 2026 09:17
@ihtefyw
ihtefyw force-pushed the luigi/fix-carmen-tests branch from f6704c9 to 8088933 Compare May 28, 2026 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants