Fix flaky TestArchiveInquirer_RunProgressReport#228
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adjusts the TestArchiveInquirer_RunProgressReport timing to reduce flakiness caused by a race between the ticker firing and the shutdown signal in the archive inquirer progress reporter.
Changes:
- Reduced the progress-report ticker interval used by the test to 500ms.
- Increased the test’s wait time before signaling shutdown to 1s to allow a tick/log to occur.
Comments suppressed due to low confidence (1)
executor/extension/statedb/archive_inquirer_test.go:318
durationis now only used for the ticker interval (the sleep is hard-coded to 1s). Renaming this variable to something liketickerDurationwould make the intent clearer and avoid confusion about what the value controls.
duration := 500 * time.Millisecond
inquirer := &archiveInquirer{
log: mockLog,
finished: utils.MakeEvent(),
tickerDuration: duration,
}
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
wsodsong
force-pushed
the
ws/fix-flacky-testarchiveinquirer
branch
from
March 27, 2026 07:40
8d0b86c to
5e0f593
Compare
cabrador
previously approved these changes
Mar 27, 2026
The test used a 1s ticker with a 1s sleep, creating a race between the ticker and the finished signal. This change reduces the ticker to 500ms so the ticker is guarantee to fire before shutdown.
wsodsong
force-pushed
the
ws/fix-flacky-testarchiveinquirer
branch
from
June 30, 2026 07:36
33e97ef to
ae908f9
Compare
rpl-ffl
self-requested a review
June 30, 2026 08:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The test used a 1s ticker with a 1s sleep, creating a race between the ticker and the finished signal. This change reduces the ticker to 500ms so the ticker is guarantee to fire before shutdown.
Type of change
Please delete options that are not relevant.