Skip to content

Support advice inpust for call command#2244

Open
marijamijailovic wants to merge 3 commits into
0xMiden:mainfrom
walnuthq:pr/call-advice-inputs
Open

Support advice inpust for call command#2244
marijamijailovic wants to merge 3 commits into
0xMiden:mainfrom
walnuthq:pr/call-advice-inputs

Conversation

@marijamijailovic

Copy link
Copy Markdown
Contributor

Closes #2094

@igamigo

igamigo commented Jun 12, 2026

Copy link
Copy Markdown
Collaborator

Hey @marijamijailovic / @Keinberger, just a heads up, if we want this on the 0.15.x we'll need to rebase this to main.

@marijamijailovic marijamijailovic changed the base branch from next to main June 15, 2026 18:55
@marijamijailovic

Copy link
Copy Markdown
Contributor Author

Hi @igamigo, this one is rebase on main.

Comment thread bin/miden-cli/src/advice_inputs.rs Outdated
Comment thread CHANGELOG.md Outdated

@igamigo igamigo left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I think we can merge this after rebasing off the latest main

@marijamijailovic

Copy link
Copy Markdown
Contributor Author

LGTM! I think we can merge this after rebasing off the latest main

Hi @igamigo, thanks! I reworked ‎resolve_procedure_digest so it now looks up the target procedure through ‎package.manifest.exports() instead of the deprecated MAST library. For packages built with the latest (next) compiler, which expose two digests for the same leaf name, we now match the bare name against the manifest exports (treating ‎_ and ‎- as equivalent) and choose the canonical-ABI export.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

miden-client call: support advice inputs via TOML

3 participants