feat(cli): expose public payback on swap command#2190
Draft
JereSalo wants to merge 6 commits into
Draft
Conversation
Adds --payback-note-type to the swap subcommand so the payback note can be created public or private (defaults to private, matching pswap's CLI). Fixes the printed payback tag to use the creator account target instead of the SWAP note's own tag. Adds swap_public_payback_test in the mock-RPC test suite, exercising build_swap end-to-end with NoteType::Public payback against the companion protocol branch. Cargo.toml temporarily redirects miden-protocol, miden-standards, miden-testing, miden-tx, miden-tx-batch-prover to a local protocol checkout via [patch], paired with the SWAP standard rewrite in protocol branch jere/swap-v2. The patch block must be removed and the protocol revision pinned normally before this is opened as a PR.
JereSalo
added
no changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
--payback-note-typeto theswapCLI so the payback note can be created public or private (default: private). Fixes the printed payback tag to use the creator account target, matching what the on-chain script derives. Public payback now works end-to-end thanks to 0xMiden/protocol#2949, and a new integration test (swap_public_payback) exercises it against a real node.Blocked on 0xMiden/protocol#2949. The integration test
swap_public_paybackwill fail in CI until that PR is merged and the protocol pin updates.Closes #1739