You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi @igamigo same question(as on #2179 ) about the changelog for this PR: there is already an entry saying “Added miden-cli call command for invoking account procedures directly from the CLI”. Should we reuse that existing entry for this PR or to add a new changelog entry?
Hi @igamigo same question(as on #2179 ) about the changelog for this PR: there is already an entry saying “Added miden-cli call command for invoking account procedures directly from the CLI”. Should we reuse that existing entry for this PR or to add a new changelog entry?
Sorry for the delay in this response. Similarly to the other PR, not a strong opinion but we can reuse the original log.
miden-client exec and call do not work with the latest compiler on the next branch. We must wait for the fix first.
See: 0xMiden/compiler#1192
After the fix is introduce, I will:
Run full testing locally.
Mark this PR as ready for review.
So this PR stays in draft until then.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds remote account support to the
callcommand: accounts not in the local store are resolved as public foreign accounts and invoked via FPI.This is Draft because I am suggesting that we first merge #2179, and then this one , which will close #2097.
cc @Keinberger, @igamigo