Skip to content

chore: bump thornode image: update to 1.0.22-23761879 (main) #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tiljrd wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore: bump thornode image: update to 1.0.22-23761879 (main) #86

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
414ef54
Merge pull request #79 from 0xBloctopus/bump-thornode-1.0.25-23761879…
tiljrd Dec 15, 2025
eac788b
chore: bump thornode image: update to 1.0.22-23761879 (main)
tiljrd Jan 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,10 +261,10 @@ chains:
app_version: "3.11.0"
forking:
enabled: true
image: "tiljordan/thornode-forking:1.0.25-23761879"
image: "tiljordan/thornode-forking:1.0.22-23761879"
height: 23015000
participants:
- image: "tiljordan/thornode-forking:1.0.25-23761879"
- image: "tiljordan/thornode-forking:1.0.22-23761879"
count: 1
account_balance: 1000000000000
bond_amount: 500000000000
Expand Down
2 changes: 1 addition & 1 deletion examples/cli-with-network.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ chains:
participants:
- type: full
count: 1
image: "tiljordan/thornode-forking:1.0.25-23761879"
image: "tiljordan/thornode-forking:1.0.22-23761879"
account_balance: 1000000000000
bond_amount: 500000000000
min_cpu: 500
Expand Down
2 changes: 1 addition & 1 deletion examples/forking-1.0.10.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ chains:
- name: thorchain
type: thorchain
participants:
- image: "tiljordan/thornode-forking:1.0.25-23761879"
- image: "tiljordan/thornode-forking:1.0.22-23761879"
account_balance: 1000000000000000
bond_amount: "300000000000000"
count: 1
Expand Down
4 changes: 2 additions & 2 deletions examples/forking-genesis.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,13 @@ chains:

forking:
enabled: true
image: "tiljordan/thornode-forking:1.0.25-23761879"
image: "tiljordan/thornode-forking:1.0.22-23761879"
height: 23043758

participants:
- type: full
count: 1
image: "tiljordan/thornode-forking:1.0.25-23761879"
image: "tiljordan/thornode-forking:1.0.22-23761879"
account_balance: 1000000000000
bond_amount: 500000000000
min_cpu: 500
Expand Down
2 changes: 1 addition & 1 deletion src/faucet/faucet_launcher.star
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ def launch_faucet(plan, chain_name, chain_id, mnemonic, transfer_amount):
)

# Use thornode forking image to get thornode CLI in container
faucet_image = "tiljordan/thornode-forking:1.0.25-23761879"
faucet_image = "tiljordan/thornode-forking:1.0.22-23761879"

# Launch the faucet service
plan.add_service(
Expand Down
2 changes: 1 addition & 1 deletion src/network_launcher/single_node_launcher.star
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ def launch_single_node(plan, chain_cfg):
config_folder = "/root/.thornode/config"

forking_config = chain_cfg.get("forking", {})
forking_image = forking_config.get("image", "tiljordan/thornode-forking:1.0.25-23761879")
forking_image = forking_config.get("image", "tiljordan/thornode-forking:1.0.22-23761879")

participant = chain_cfg["participants"][0]
node_volume_size = participant.get("persistent_size_mb", chain_cfg.get("node_persistent_size_mb", 16384))
Expand Down
4 changes: 2 additions & 2 deletions src/package_io/thorchain_defaults.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@
{
"type": "full",
"count": 1,
"image": "tiljordan/thornode-forking:1.0.25-23761879",
"image": "tiljordan/thornode-forking:1.0.22-23761879",
"account_balance": 1000000000000,
"bond_amount": 500000000000,
"min_cpu": 1000,
Expand All @@ -68,7 +68,7 @@
],
"forking": {
"enabled": true,
"image": "tiljordan/thornode-forking:1.0.25-23761879",
"image": "tiljordan/thornode-forking:1.0.22-23761879",
"grpc": "grpc.thor.pfc.zone:443",
"chain_id": "thorchain-1",
"height": 23043758,
Expand Down
2 changes: 1 addition & 1 deletion src/toolchain-cli/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM tiljordan/thornode-forking:1.0.25-23761879
FROM tiljordan/thornode-forking:1.0.22-23761879

@coderabbitai coderabbitai Bot Jan 10, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

# Check the git history of the Dockerfile to see the previous version
git log --oneline src/toolchain-cli/Dockerfile | head -20

Repository: 0xBloctopus/thorchain-package

Length of output: 141

🏁 Script executed:

# Get the specific commit that changed this file
git log -p src/toolchain-cli/Dockerfile | head -100

Repository: 0xBloctopus/thorchain-package

Length of output: 55

🏁 Script executed:

# Check the current state and recent changes
git diff HEAD~5 HEAD -- src/toolchain-cli/Dockerfile

Repository: 0xBloctopus/thorchain-package

Length of output: 103

🏁 Script executed:

# Look for any PR or issue references in recent commits
git log --all --grep="thornode\|Dockerfile\|version\|bump" --oneline | head -20

Repository: 0xBloctopus/thorchain-package

Length of output: 1562

🏁 Script executed:

git show eac788b --no-patch

Repository: 0xBloctopus/thorchain-package

Length of output: 295

🏁 Script executed:

# Check for any related issues or PR discussions
git log eac788b^..eac788b --format=fuller

Repository: 0xBloctopus/thorchain-package

Length of output: 272

Verify the reason for this intentional version downgrade.

The change downgrades the base image from 1.0.25-23761879 to 1.0.22-23761879. The commit message indicates this is part of an "Automated weekly bump," suggesting the upstream image maintainer (tiljordan) has updated what is considered the stable version. However, this downgrade warrants clarification:

  1. Was 1.0.25-23761879 intentionally yanked or removed from the registry?
  2. Is there a documented reason for preferring 1.0.22 (e.g., critical bug in 1.0.25)?
  3. Does the versioning scheme differ from standard semantic versioning (where 1.0.25 > 1.0.22)?

Confirm with the upstream maintainer or check the thornode release notes if there are known issues with 1.0.25.

🤖 Prompt for AI Agents 
In @src/toolchain-cli/Dockerfile at line 1, The Dockerfile's FROM line was
changed to use tiljordan/thornode-forking:1.0.22-23761879 (previously
1.0.25-23761879); verify and document why this appears to be a downgrade by
checking the upstream image registry and thornode/tiljordan release notes,
confirm whether 1.0.25-23761879 was removed or has a known critical issue, and
if so update the PR description or commit message with the justification (or
restore the original tag if the downgrade was accidental); reference the
Dockerfile's FROM instruction and the specific image tags
(tiljordan/thornode-forking:1.0.22-23761879 and
tiljordan/thornode-forking:1.0.25-23761879) when making the verification and
updating the PR.


SHELL ["/bin/bash", "-lc"]

Expand Down