Skip to content

chore: bump thornode image: update to 1.0.27-23761879 (main) - #82

Open
tiljrd wants to merge 2 commits into
mainfrom
bump-thornode-1.0.27-23761879-main
Open

chore: bump thornode image: update to 1.0.27-23761879 (main)#82
tiljrd wants to merge 2 commits into
mainfrom
bump-thornode-1.0.27-23761879-main

Conversation

@tiljrd

@tiljrd tiljrd commented Dec 27, 2025

Copy link
Copy Markdown
Contributor

User description

Automated: bump image to tiljordan/thornode-forking:1.0.27-23761879 on base main. Automated weekly bump.


PR Type

Other


Description

  • Update thornode-forking image version from 1.0.25 to 1.0.27

  • Bump image tag across all configuration files and examples

  • Update default image reference in JSON defaults configuration

  • Update Dockerfile base image to latest version


Diagram Walkthrough

flowchart LR
  A["thornode-forking<br/>1.0.25-23761879"] -- "version bump" --> B["thornode-forking<br/>1.0.27-23761879"]
  B --> C["README.md"]
  B --> D["Configuration Files"]
  B --> E["Dockerfile"]
  B --> F["JSON Defaults"]
Loading

File Walkthrough

Relevant files
Configuration changes
README.md
Update thornode image references in documentation               

README.md

  • Updated thornode-forking image version in forking configuration from
    1.0.25 to 1.0.27
  • Updated image version in participants section from 1.0.25 to 1.0.27
+2/-2     
cli-with-network.yaml
Bump thornode image in CLI example config                               

examples/cli-with-network.yaml

  • Updated participant image version from 1.0.25-23761879 to
    1.0.27-23761879
+1/-1     
forking-1.0.10.yaml
Bump thornode image in forking example                                     

examples/forking-1.0.10.yaml

  • Updated participant image version from 1.0.25-23761879 to
    1.0.27-23761879
+1/-1     
forking-genesis.yaml
Bump thornode image in genesis forking example                     

examples/forking-genesis.yaml

  • Updated forking image version from 1.0.25-23761879 to 1.0.27-23761879
  • Updated participant image version from 1.0.25-23761879 to
    1.0.27-23761879
+2/-2     
faucet_launcher.star
Update thornode image in faucet launcher                                 

src/faucet/faucet_launcher.star

  • Updated faucet_image variable from 1.0.25-23761879 to 1.0.27-23761879
+1/-1     
single_node_launcher.star
Update thornode image in single node launcher                       

src/network_launcher/single_node_launcher.star

  • Updated default forking_image version from 1.0.25-23761879 to
    1.0.27-23761879
+1/-1     
thorchain_defaults.json
Bump thornode image in default configuration                         

src/package_io/thorchain_defaults.json

  • Updated participant image version from 1.0.25-23761879 to
    1.0.27-23761879
  • Updated forking image version from 1.0.25-23761879 to 1.0.27-23761879
+2/-2     
Dependencies
Dockerfile
Update Dockerfile base image version                                         

src/toolchain-cli/Dockerfile

  • Updated base image FROM clause from 1.0.25-23761879 to 1.0.27-23761879
+1/-1     

Summary by CodeRabbit

  • Chores
    • Updated thornode-forking Docker image references from version 1.0.25-23761879 to version 1.0.27-23761879 throughout the platform, including all deployment configurations, service launchers, default package settings, example manifests, and Docker build tooling. This ensures all components and services consistently utilize the latest stable release available, maintaining uniformity and full compatibility across the entire system.

✏️ Tip: You can customize this high-level summary in your review settings.

tiljrd and others added 2 commits December 15, 2025 15:28
…-main

chore: bump thornode image: update to 1.0.25-23761879 (main)
@coderabbitai

coderabbitai Bot commented Dec 27, 2025

Copy link
Copy Markdown

Walkthrough

This PR updates the thornode-forking Docker image version from 1.0.25-23761879 to 1.0.27-23761879 across eight configuration files, example YAMLs, launcher code, and a Dockerfile with no behavioral changes.

Changes

Cohort / File(s) Summary
Documentation & Configuration Examples
README.md, examples/cli-with-network.yaml, examples/forking-1.0.10.yaml, examples/forking-genesis.yaml
Updated thornode-forking image references from 1.0.25-23761879 to 1.0.27-23761879 across multiple YAML configurations and documentation
Source Configuration & Defaults
src/network_launcher/single_node_launcher.star, src/package_io/thorchain_defaults.json, src/faucet/faucet_launcher.star
Updated default and configured image tag references for thornode-forking service from 1.0.25-23761879 to 1.0.27-23761879
Docker Tooling
src/toolchain-cli/Dockerfile
Updated base image from tiljordan/thornode-forking:1.0.25-23761879 to 1.0.27-23761879

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested labels

review-effort/1-trivial, type/maintenance, scope/images

Poem

🐰 A version bump hops through the land,
From twenty-five to twenty-seven it stands,
Docker tags dance in harmony's grace,
Eight files updated at a consistent pace! 🏃‍♂️

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically summarizes the main change: bumping the thornode image to version 1.0.27-23761879, which is exactly what the changeset does across all modified files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch bump-thornode-1.0.27-23761879-main

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 414ef54 and 6ea4380.

📒 Files selected for processing (8)
  • README.md
  • examples/cli-with-network.yaml
  • examples/forking-1.0.10.yaml
  • examples/forking-genesis.yaml
  • src/faucet/faucet_launcher.star
  • src/network_launcher/single_node_launcher.star
  • src/package_io/thorchain_defaults.json
  • src/toolchain-cli/Dockerfile
🔇 Additional comments (8)
examples/cli-with-network.yaml (1)

10-10: Image version updated consistently.

The thornode-forking image has been updated to 1.0.27-23761879, consistent with the PR's objective to bump the image version across all configuration files.

src/package_io/thorchain_defaults.json (1)

57-57: Image references updated consistently.

Both the participant image and forking image have been updated to 1.0.27-23761879, maintaining consistency throughout the default configuration.

Also applies to: 71-71

README.md (1)

264-264: Documentation examples updated to match new image version.

The README examples now reference the updated image version 1.0.27-23761879, keeping documentation synchronized with the actual configuration defaults.

Also applies to: 267-267

src/faucet/faucet_launcher.star (1)

33-33: Faucet service image updated consistently.

The faucet launcher now uses the updated thornode-forking image version 1.0.27-23761879, consistent with other services in the package.

src/toolchain-cli/Dockerfile (1)

1-1: Dockerfile base image updated consistently.

The CLI toolchain Dockerfile now builds from the updated thornode-forking:1.0.27-23761879 base image, maintaining consistency with the rest of the package.

examples/forking-1.0.10.yaml (1)

5-5: Example configuration updated with new image version.

The forking example now uses the updated image version 1.0.27-23761879, keeping examples synchronized with defaults.

examples/forking-genesis.yaml (1)

10-10: Both image references in example updated consistently.

The forking genesis example now uses the updated image version 1.0.27-23761879 for both the forking image and participant image, maintaining consistency.

Also applies to: 16-16

src/network_launcher/single_node_launcher.star (1)

12-12: Default forking image updated consistently.

The default fallback image has been updated to 1.0.27-23761879 across all configuration files, with no remaining references to the old version 1.0.25-23761879. Verified consistency in:

  • src/network_launcher/single_node_launcher.star (line 12)
  • src/package_io/thorchain_defaults.json
  • src/faucet/faucet_launcher.star
  • src/toolchain-cli/Dockerfile
  • All example configuration files (forking-genesis.yaml, forking-1.0.10.yaml, cli-with-network.yaml)
  • README.md

Docker image availability and version compatibility between 1.0.25 and 1.0.27 should be confirmed in your deployment environment.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@qodo-code-review

Copy link
Copy Markdown
ⓘ Your approaching your monthly quota for Qodo. Upgrade your plan

PR Compliance Guide 🔍

Below is a summary of compliance checks for this PR:

Security Compliance
Unpinned container image

Description: The PR updates multiple references to the third-party image
tiljordan/thornode-forking:1.0.27-23761879 (including the Dockerfile base image), and
because it is referenced by a mutable tag rather than an immutable digest (e.g.,
@sha256:...), a compromised registry/account or tag retargeting could silently change the
deployed code (supply-chain risk); consider pinning to a digest and/or verifying
provenance/signatures for this image.
Dockerfile [1-1]

Referred Code
FROM tiljordan/thornode-forking:1.0.27-23761879
Ticket Compliance
🎫 No ticket provided
  • Create ticket/issue
Codebase Duplication Compliance
Codebase context is not defined

Follow the guide to enable codebase context checks.

Custom Compliance
🟢
Generic: Comprehensive Audit Trails

Objective: To create a detailed and reliable record of critical system actions for security analysis
and compliance.

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Meaningful Naming and Self-Documenting Code

Objective: Ensure all identifiers clearly express their purpose and intent, making code
self-documenting

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Robust Error Handling and Edge Case Management

Objective: Ensure comprehensive error handling that provides meaningful context and graceful
degradation

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Secure Error Handling

Objective: To prevent the leakage of sensitive system information through error messages while
providing sufficient detail for internal debugging.

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Secure Logging Practices

Objective: To ensure logs are useful for debugging and auditing without exposing sensitive
information like PII, PHI, or cardholder data.

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Security-First Input Validation and Data Handling

Objective: Ensure all data inputs are validated, sanitized, and handled securely to prevent
vulnerabilities

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Compliance status legend 🟢 - Fully Compliant
🟡 - Partial Compliant
🔴 - Not Compliant
⚪ - Requires Further Human Verification
🏷️ - Compliance label

@qodo-code-review

Copy link
Copy Markdown
ⓘ Your approaching your monthly quota for Qodo. Upgrade your plan

PR Code Suggestions ✨

Explore these optional code suggestions:

CategorySuggestion                                                                                                                                    Impact
General
Centralize hardcoded image version string

To improve maintainability, centralize the hardcoded thornode-forking image
version by defining it as a constant in a shared module and importing it where
needed.

src/network_launcher/single_node_launcher.star [12]

-forking_image = forking_config.get("image", "tiljordan/thornode-forking:1.0.27-23761879")
+# In a new file like 'src/constants.star'
+# THORNODE_FORKING_IMAGE = "tiljordan/thornode-forking:1.0.27-23761879"
 
+# In 'src/network_launcher/single_node_launcher.star'
+# constants = import_module("./constants.star")
+forking_image = forking_config.get("image", constants.THORNODE_FORKING_IMAGE)
+
  • Apply / Chat
Suggestion importance[1-10]: 7

__

Why: This is a valid and valuable suggestion that addresses a clear maintainability issue, as evidenced by the PR's changes across multiple files. Centralizing the version string into a constant is a best practice that would prevent future errors and simplify updates.

Medium
Use ARG for base image version

In the Dockerfile, use an ARG instruction to parameterize the hardcoded base
image version, allowing it to be passed during the build process for better
maintainability.

src/toolchain-cli/Dockerfile [1]

-FROM tiljordan/thornode-forking:1.0.27-23761879
+ARG THORNODE_FORKING_IMAGE_TAG=1.0.27-23761879
+FROM tiljordan/thornode-forking:${THORNODE_FORKING_IMAGE_TAG}
  • Apply / Chat
Suggestion importance[1-10]: 7

__

Why: This suggestion correctly identifies a maintainability issue in the Dockerfile and proposes the standard best practice of using ARG to parameterize the base image version. This makes the build process more flexible and easier to manage.

Medium
  • More

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant