Remove BOM from PublishClient.sh.#183
Open
Teemuerik wants to merge 1 commit into
Open
Conversation
The PublishClient.sh file contained a Byte Order Mark at the start. This is an invisible byte sequence at the start of the file that exists mostly for legacy applications, but is not recommended. In this case, it caused the following mostly harmless error: ./PublishClient.sh: line 1: #!/bin/sh: No such file or directory The "shebang" line has to be the first line with nothing before it, so the program loader throws this error since there is a byte sequence before it (the BOM).
Author
|
To add even more detail: This can be checked on linux with the command Raw file contents with previous version: Which gave the following output when run (only start shown): Raw file contents with this version: Which gives the following output when run (no error, only start shown): I know this is a pretty small fix, but thought I should get this out of the way first, since it would not make sense to include in a Ghost client code PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PublishClient.sh file contained a Byte Order Mark at the start. This is an invisible byte sequence at the start of the file that exists mostly for legacy applications, but is not recommended. In this case, it caused the following mostly harmless error:
./PublishClient.sh: line 1: #!/bin/sh: No such file or directory
The "shebang" line has to be the first line with nothing before it, so the program loader throws this error since there is a byte sequence before it (the BOM).