fix: Linux release glibc compatibility - #46
Merged
Merged
Conversation
0dragosh
marked this pull request as ready for review
April 16, 2026 09:01
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #45
Build Linux release artifacts on Ubuntu 22.04 instead of
ubuntu-latestso the published GNU binaries stay compatible with Ubuntu 22.04 / glibc 2.35 environments.Root Cause
The release workflow was building
x86_64-unknown-linux-gnuandaarch64-unknown-linux-gnuartifacts onubuntu-latest, which can link against a newer glibc than Ubuntu 22.04 provides. That makescargo-binstallinstalls fail at runtime with errors likeGLIBC_2.39 not found.Changes
ubuntu-22.04ubuntu-latestValidation
cargo test --locked test_release_linux_binaries_target_ubuntu_22_04nix develop -c cargo fmt --all -- --checknix develop -c cargo clippy --locked --all-targets -- -D warningsNotes
cargo test --locked --all-targetsstill fails on this nix-darwin machine in three pre-existing hook integration tests unrelated to this workflow change:test_hooks_install_adds_managed_hook_even_with_other_cwt_like_commandtest_hooks_install_patches_settings_jsontest_hooks_install_idempotent