Skip to content

Fix Rekordbox USB key sorting - #21

Open
0cwa wants to merge 1 commit into
mixxx/mainfrom
fix/rekordbox-usb-13624
Open

Fix Rekordbox USB key sorting#21
0cwa wants to merge 1 commit into
mixxx/mainfrom
fix/rekordbox-usb-13624

Conversation

@0cwa

@0cwa 0cwa commented Aug 12, 2026

Copy link
Copy Markdown
Owner

Summary

  • Add the missing key_id column to the temporary Rekordbox library table.
  • Populate key_id from imported Rekordbox key text and include it in inserts.
  • Keep this branch limited to the issue-specific schema/import fix; memory-cue and ANLZ changes are intentionally excluded.

Context

Issue mixxxdj#13624 includes a failed query ordering rekordbox_library by key_id. This change supplies that column and value, addressing the likely cause of the Rekordbox USB library/interface failure described in the issue.

Validation

  • git diff --check passes.
  • The branch net diff is one file with only the key_id schema/import/query changes.
  • The changed code was compiled as part of the recent combined Mixxx engine integration build; this PR is opened against mixxx/main to trigger the repository CI, including the macOS build, for further validation.
  • No physical Rekordbox USB fixture was available locally.

This branch and PR description were prepared by ChatGPT/Codex in this workspace at the user's request.

Related: mixxxdj#13624

@coderabbitai

coderabbitai Bot commented Aug 12, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 24aa9f90-d6bc-4c12-92b5-b41da1d2fff8

📥 Commits

Reviewing files that changed from the base of the PR and between 9e670c1 and 65346f8.

📒 Files selected for processing (1)
  • src/library/rekordbox/rekordboxfeature.cpp

📝 Walkthrough

Walkthrough

Rekordbox track storage now includes a numeric key_id. Track insertion derives this value from the imported textual key and persists it with the track record.

Changes

Rekordbox key ID persistence

Layer / File(s) Summary
Add key ID schema
src/library/rekordbox/rekordboxfeature.cpp
The Rekordbox library table now includes an integer key_id column.
Derive and insert key ID
src/library/rekordbox/rekordboxfeature.cpp
Track insertion uses KeyUtils::guessKeyFromText and includes the bound numeric key ID in the library INSERT statement.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: joergatgithub

Poem

A rabbit found a key in the tune,
And stored its number beneath the moon.
The text stayed bright,
The ID fit right,
Rekordbox hopped in sync by noon.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the main change: fixing Rekordbox USB key sorting.
Description check ✅ Passed The description directly explains the key_id schema, import, query, and validation changes.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 2
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/rekordbox-usb-13624

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coveralls

Copy link
Copy Markdown

Coverage Report for CI Build 31638276396

Warning

No base build found for commit 9e670c1 on mixxx/main.
Coverage changes can't be calculated without a base build.
If a base build is processing, this comment will update automatically when it completes.

Coverage: 30.156%

Details

  • Patch coverage: 2 uncovered changes across 1 file (0 of 2 lines covered, 0.0%).

Uncovered Changes

File Changed Covered %
src/library/rekordbox/rekordboxfeature.cpp 2 0 0.0%

Coverage Regressions

Requires a base build to compare against. How to fix this →


Coverage Stats

Coverage Status
Relevant Lines: 117194
Covered Lines: 35341
Line Coverage: 30.16%
Coverage Strength: 54482.17 hits per line

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants