Add ontology decision import preview#549
Merged
Merged
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9573ea4ab0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds SG-RFC-0115, a read-only
ontology_decision_import_previewartifact that joins the ontology review dashboard with Ontology owner decisions before any future import workflow.Motivation
After the dashboard and owner-decision report slices, SpecGraph needs a deterministic preview that shows whether accepted/rejected Ontology decisions are blocked, ready for operator review, rejected, clarification-needed, or unmatched without applying those decisions.
Goals
Add the preview contract, builder, validator, docs, registry trace, and tests. Out of scope: applying owner decisions, importing into SpecGraph, closing semantic gates, writing Ontology packages or lockfiles, mutating canonical specs, or adding SpecSpace mutation UI.
Changes
ontology_decision_import_preview_contractto the semantic control policy and wires the preview intotools/ontology_imports.py.Validation
Commands run:
Results:
tests/test_ontology_import_policy.py: 73 passedproposal-tracking-gate: passed, 115 tracked, 0 blockersdocc-sync: passedruff check: passedmake test: 1201 passedRisks / Notes
build_specspace_owner_decision_review_surface.Checklist